You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/03/08 01:01:50 UTC
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6311
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
IMPALA-4711: clarify is_null semantics in udf.h
This is to reduce the chance of confusion about what the UDF interface
guarantees. E.g. I've seen users post code that assumes that the len
field of a NULL StringVal is 0, which we do not guarantee.
Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
---
M be/src/udf/udf.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/6311/1
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6311/1/be/src/udf/udf.h
File be/src/udf/udf.h:
PS1, Line 410: particular
> particular value ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
IMPALA-4711: clarify is_null semantics in udf.h
This is to reduce the chance of confusion about what the UDF interface
guarantees. E.g. I've seen users post code that assumes that the len
field of a NULL StringVal is 0, which we do not guarantee.
Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Reviewed-on: http://gerrit.cloudera.org:8080/6311
Tested-by: Impala Public Jenkins
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/udf/udf.h
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/356/
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6311
to look at the new patch set (#2).
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
IMPALA-4711: clarify is_null semantics in udf.h
This is to reduce the chance of confusion about what the UDF interface
guarantees. E.g. I've seen users post code that assumes that the len
field of a NULL StringVal is 0, which we do not guarantee.
Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
---
M be/src/udf/udf.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/6311/2
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6311/1/be/src/udf/udf.h
File be/src/udf/udf.h:
PS1, Line 410: particular
particular value ?
--
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes