You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/06/08 00:02:55 UTC

[GitHub] [superset] eschutho opened a new pull request, #24317: fix: update order of build for testing a release

eschutho opened a new pull request, #24317:
URL: https://github.com/apache/superset/pull/24317

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Due to a recent change in [dataset permissions](https://github.com/apache/superset/pull/23200/files) the release testing file needed to be updated in order to ensure that the correct permissions were build before running the tarball.
   
   This change only impacts the release testing process.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho merged pull request #24317: fix: update order of build for testing a release

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho merged PR #24317:
URL: https://github.com/apache/superset/pull/24317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on pull request #24317: fix: update order of build for testing a release

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24317:
URL: https://github.com/apache/superset/pull/24317#issuecomment-1583580315

   Sure, no problem. @betodealmeida also showed me [this pr](https://github.com/apache/superset/pull/23600) that loads examples as an anonymous user and should take care of any problems loading before running init, but at least this is all consistent now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley commented on pull request #24317: fix: update order of build for testing a release

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24317:
URL: https://github.com/apache/superset/pull/24317#issuecomment-1583027818

   @eschutho grokking the rest of the codebase it seems like the order is mostly correct, i.e., how you've defined it, except for [this](https://github.com/apache/superset/blob/69c2cd5f40b878ad88b4ce59c64b5430c918d314/docs/docs/contributing/testing-locally.mdx?plain=1#L96-L97). Would you mind also updating said logic there as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org