You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/28 10:29:50 UTC
[GitHub] [incubator-linkis] ws00428637 opened a new pull request, #2545: Add Trino supports
ws00428637 opened a new pull request, #2545:
URL: https://github.com/apache/incubator-linkis/pull/2545
### What is the purpose of the change
EngineConn-Plugin for Trino
Related issues: #2409.
### Brief change log
- Define an executor base on Trino jdbc client
- Add progress support for Trino on jdbc plugin
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- Anything that affects deployment: don't know
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2545: Add Trino supports
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2545:
URL: https://github.com/apache/incubator-linkis/pull/2545#discussion_r936610697
##########
tool/dependencies/known-dependencies.txt:
##########
@@ -140,8 +147,10 @@ flink-table-common-1.12.2.jar
flink-table-planner-blink_2.11-1.12.2.jar
flink-table-runtime-blink_2.11-1.12.2.jar
flink-yarn_2.11-1.12.2.jar
+flyway-core-6.4.4.jar
Review Comment:
the dependency jar should deal with guide of
https://linkis.apache.org/zh-CN/community/development_specification/license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2545: Add Trino supports
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2545:
URL: https://github.com/apache/incubator-linkis/pull/2545#issuecomment-1199496282
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2545](https://codecov.io/gh/apache/incubator-linkis/pull/2545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8626d8) into [dev-1.2.1](https://codecov.io/gh/apache/incubator-linkis/commit/70fc6ccffe425de02b2b41a143acbc8d39ddbe17?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70fc6cc) will **increase** coverage by `0.12%`.
> The diff coverage is `58.46%`.
```diff
@@ Coverage Diff @@
## dev-1.2.1 #2545 +/- ##
===============================================
+ Coverage 15.78% 15.91% +0.12%
- Complexity 1105 1114 +9
===============================================
Files 668 670 +2
Lines 20632 20693 +61
Branches 2941 2950 +9
===============================================
+ Hits 3257 3293 +36
- Misses 16938 16958 +20
- Partials 437 442 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eplugin/jdbc/executer/JDBCEngineConnExecutor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9qZGJjL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL21hbmFnZXIvZW5naW5lcGx1Z2luL2pkYmMvZXhlY3V0ZXIvSkRCQ0VuZ2luZUNvbm5FeGVjdXRvci5zY2FsYQ==) | `13.45% <21.05%> (+0.46%)` | :arrow_up: |
| [...plugin/jdbc/monitor/impl/TrinoProgressMonitor.java](https://codecov.io/gh/apache/incubator-linkis/pull/2545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9qZGJjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vamRiYy9tb25pdG9yL2ltcGwvVHJpbm9Qcm9ncmVzc01vbml0b3IuamF2YQ==) | `65.21% <65.21%> (ø)` | |
| [...ger/engineplugin/jdbc/monitor/ProgressMonitor.java](https://codecov.io/gh/apache/incubator-linkis/pull/2545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9qZGJjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vamRiYy9tb25pdG9yL1Byb2dyZXNzTW9uaXRvci5qYXZh) | `80.95% <80.95%> (ø)` | |
| [...s/manager/engineplugin/jdbc/ConnectionManager.java](https://codecov.io/gh/apache/incubator-linkis/pull/2545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9qZGJjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vamRiYy9Db25uZWN0aW9uTWFuYWdlci5qYXZh) | `44.54% <100.00%> (+1.42%)` | :arrow_up: |
| [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `32.07% <0.00%> (-1.89%)` | :arrow_down: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] ws00428637 closed pull request #2545: Add Trino supports
Posted by GitBox <gi...@apache.org>.
ws00428637 closed pull request #2545: Add Trino supports
URL: https://github.com/apache/incubator-linkis/pull/2545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2545: Add Trino supports
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2545:
URL: https://github.com/apache/incubator-linkis/pull/2545#discussion_r936388825
##########
linkis-computation-governance/linkis-client/linkis-computation-client/src/main/scala/org/apache/linkis/ujes/client/utils/UJESClientUtils.scala:
##########
@@ -42,6 +43,7 @@ object UJESClientUtils {
case "hql" => EngineType.HIVE.HQL
case "shell" => EngineType.SHELL.SH
case "python" => EngineType.PYTHON.PY
+ case "tql" => EngineType.TRINO.TSQL
Review Comment:
be consistent, use tsql?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org