You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Musachy Barroso (JIRA)" <ji...@apache.org> on 2006/12/04 16:02:57 UTC
[jira] Created: (WW-1536) TabbedPanel improvements
TabbedPanel improvements
------------------------
Key: WW-1536
URL: http://issues.apache.org/struts/browse/WW-1536
Project: Struts 2
Issue Type: Improvement
Components: Views
Affects Versions: 2.0.2
Reporter: Musachy Barroso
Priority: Minor
1) Does it really need to download 500+ kB of javascript and related
code to display a set of empty tabs? Can it be compressed somehow? Any
switches for that?
2) Why does that javascript and related code get reloaded every time?
I try to enter the page with tabs again (not forcing reload with SHIFT) and
all that stuff is fetched again.
Can it be something with http headers?
The total amount of data that is sent is really frustrating me.
3) In addition to that I could observe 16 multiple requests for
GET /myApp/struts/xhtml/styles.css HTTP/1.1
to display single HTML page with 7 remote panels
(test, all panels referring the same simple page with 1 test
sentence - nothing more).
4) It is not written anywhere in docs - but these tabs do not work if the S2
application uses 'html' for action extension (overriding the default).
Some of the resources returned by Struts for tabbedPanel also end
with 'html'
and the struts controller sees a problem.
GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
I can only see a stacktrace that such action is not defined in my app,
dojo does not get such page and instead of tabs I can only see
error message
in the browser.
After I changed the extension for my actions to something else -
it started to work.
But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Dariusz Wojtas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=all ]
Dariusz Wojtas updated WW-1536:
-------------------------------
Attachment: FilterDispatcher_patch.patch
This patch adds support for If-Modified-Since header for serving static content.
It also fixes the response date formatting
a) no more thread-unsafe formatter instances
b) no more playing with GMT and other timezones - there were issues with calculations seen during debug and interaction with the browser
Basically it uses
response.setDateHeader(name, millis);
for date specific headers.
Let the container do what it is supposed to do.
I tested this patch and observed headers sent between 2 machines.
After this patch it started to work correctly. If-Modified-Since works as expected, much less data sent in subsequent requests.
Also dates started to have correct timezone calculation.
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=all ]
Ted Husted updated WW-1536:
---------------------------
Flags: [Patch]
Fix Version/s: 2.0.2
(was: 2.0.x)
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.2
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39672 ]
Don Brown commented on WW-1536:
-------------------------------
What is really left in this issue to accomplish? I'd prefer we avoid these general issue tickets as they are best left to the dev list or a forum to sort out, then once it is determined what needs to be done, file a ticket. That way, they are easier for someone to resolve them later. Glad to see the static file caching fix come out of this, though.
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.3
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Dariusz Wojtas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=comments#action_38982 ]
Dariusz Wojtas commented on WW-1536:
------------------------------------
The static content is served by the main Struts2 Filter:
org.apache.struts2.dispatcher.FilterDispatcher
method:
findStaticResource(String, HttpServletResponse)
Fix for 2) should be applied inside this method.
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (WW-1536) TabbedPanel improvements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso reassigned WW-1536:
-----------------------------------
Assignee: Musachy Barroso
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Assigned To: Musachy Barroso
> Priority: Minor
> Fix For: 2.1.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Dariusz Wojtas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=comments#action_38976 ]
Dariusz Wojtas commented on WW-1536:
------------------------------------
Ad 2)
Most likely this is caused by the fact that the servlet sending static content does not respect the 'If-Modified-Since' request header.
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted updated WW-1536:
---------------------------
Fix Version/s: (was: 2.0.x)
2.1.x
Bumping issues to 2.1.x, except those that involve backward-compatability with Struts 1 or WebWork 2.
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.1.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Dariusz Wojtas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=comments#action_39014 ]
Dariusz Wojtas commented on WW-1536:
------------------------------------
One more comment on the 'date' issue. It seems to prove that there were problems with the current implementation of setting date headers.
I am now using the patched version of the code (see attached patch). Works nicely as expected.
But recently I called my application from another machine that was not accessing the app after patching it.
It has sent the 'If-Modified-Since' header with wrong value (as it was set by the orig Struts code, locale PL) and the
long ifModifiedSince = request.getDateHeader("If-Modified-Since");
line in the patched code threw an exception (invalid format).
I think that there could be extra try/catch block added in the patched code to prevent exception if somebody used it before. In case of exception - set ifModifiedSince to -1
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=comments#action_38977 ]
Musachy Barroso commented on WW-1536:
-------------------------------------
We could have a pre-built profile for the files that we use in the ajaxtags:
To create profiles: ttp://manual.dojotoolkit.org/WikiHome/DojoDotBook/Book94
To compress the js: http://dojotoolkit.org/docs/compressor_system.html
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=all ]
Ted Husted updated WW-1536:
---------------------------
Fix Version/s: 2.0.3
(was: 2.0.2)
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.3
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39675 ]
Musachy Barroso commented on WW-1536:
-------------------------------------
The only thing left is the creation of the profile to improve loading and caching which is the first thing I'm going to do after the GA. (Really easy to do)
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.3
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=all ]
Ted Husted updated WW-1536:
---------------------------
Fix Version/s: 2.0.x
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1536) TabbedPanel improvements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-1536.
---------------------------------
Resolution: Fixed
I added a "cache" property that wen set to true, a custom dojo profile will be used, making it possible to cache the javascript files on the browser. This property is false by default. Here is the dojo profile used:
var dependencies = [
"dojo.io.*",
"dojo.io.BrowserIO",
"dojo.event.*",
"dojo.lfx.*",
"dojo.namespaces.*",
"dojo.widget.Editor2",
"struts.widget.*",
];
and here is the list of files that dojo compiled into the profile:
dojoGuardStart.js
../src/bootstrap1.js
../src/loader.js
dojoGuardEnd.js
../src/hostenv_browser.js
../src/string/common.js
../src/string.js
../src/lang/common.js
../src/lang/extras.js
../src/io/common.js
../src/lang/array.js
../src/lang/func.js
../src/string/extras.js
../src/dom.js
../src/undo/browser.js
../src/io/BrowserIO.js
../src/io/cookie.js
../src/io/__package__.js
../src/event/common.js
../src/event/topic.js
../src/event/browser.js
../src/event/__package__.js
../src/gfx/color.js
../src/lfx/Animation.js
../src/html/common.js
../src/uri/Uri.js
../src/html/style.js
../src/html/display.js
../src/html/color.js
../src/html/layout.js
../src/lfx/html.js
../src/lfx/__package__.js
../__package__.js
../src/xml/Parse.js
../src/lang/declare.js
../src/ns.js
../src/widget/Manager.js
../src/uri/__package__.js
../src/a11y.js
../src/widget/Widget.js
../src/widget/Parse.js
../src/widget/DomWidget.js
../src/html/util.js
../src/lfx/toggle.js
../src/widget/HtmlWidget.js
../src/widget/__package__.js
../src/html/__package__.js
../src/html/selection.js
../src/Deferred.js
../src/widget/RichText.js
../src/lang/type.js
../src/lang/assert.js
../src/AdapterRegistry.js
../src/lang/repr.js
../src/lang/__package__.js
../src/html/iframe.js
../src/widget/PopupContainer.js
../src/widget/ColorPalette.js
../src/widget/ContentPane.js
../src/widget/Editor2Toolbar.js
../src/uri/cache.js
../src/lfx/shadow.js
../src/widget/html/layout.js
../src/dnd/DragAndDrop.js
../src/dnd/HtmlDragManager.js
../src/dnd/HtmlDragAndDrop.js
../src/dnd/__package__.js
../src/dnd/HtmlDragMove.js
../src/widget/Dialog.js
../src/widget/ResizeHandle.js
../src/widget/FloatingPane.js
../src/widget/Editor2Plugin/AlwaysShowToolbar.js
../src/widget/Editor2.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/Bind.js
../src/lang/timing/Timer.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/BindDiv.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/BindAnchor.js
../src/widget/html/stabile.js
../src/widget/ComboBox.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/ComboBox.js
../src/widget/DropdownContainer.js
../src/date/serialize.js
../src/date/common.js
../src/date/supplemental.js
../src/i18n/common.js
../src/date/format.js
../src/widget/TimePicker.js
../src/widget/DropdownTimePicker.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/StrutsTimePicker.js
../src/widget/DatePicker.js
../src/widget/DropdownDatePicker.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/StrutsDatePicker.js
../../struts/2_1/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts/widget/__package__.js
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Assigned To: Musachy Barroso
> Priority: Minor
> Fix For: 2.1.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-1536) TabbedPanel improvements
Posted by "Dariusz Wojtas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1536?page=comments#action_39157 ]
Dariusz Wojtas commented on WW-1536:
------------------------------------
I have filled issue WW-1573 which covers problem 2) as it is something more general and I think it should be separated. I hope that having it separated may speed up the proces of analizing the issue.
My previous comments here were in fact about the issue 2)
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: http://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-1536:
--------------------------
Fix Version/s: (was: 2.0.3)
2.0.x
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Priority: Minor
> Fix For: 2.0.x
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1536) TabbedPanel improvements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso updated WW-1536:
--------------------------------
Fix Version/s: (was: 2.1.x)
2.1.0
> TabbedPanel improvements
> ------------------------
>
> Key: WW-1536
> URL: https://issues.apache.org/struts/browse/WW-1536
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.0.2
> Reporter: Musachy Barroso
> Assigned To: Musachy Barroso
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: FilterDispatcher_patch.patch
>
>
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
> I try to enter the page with tabs again (not forcing reload with SHIFT) and
> all that stuff is fetched again.
> Can it be something with http headers?
> The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
> GET /myApp/struts/xhtml/styles.css HTTP/1.1
> to display single HTML page with 7 remote panels
> (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
> application uses 'html' for action extension (overriding the default).
> Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
> and the struts controller sees a problem.
> GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
> I can only see a stacktrace that such action is not defined in my app,
> dojo does not get such page and instead of tabs I can only see
> error message
> in the browser.
> After I changed the extension for my actions to something else -
> it started to work.
> But it took me 30 minutes to understand the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.