You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/28 11:21:21 UTC
[GitHub] [inlong] xuesongxs opened a new pull request, #6055: [INLONG-5978][Manager] Add protocol type in cluster nodes
xuesongxs opened a new pull request, #6055:
URL: https://github.com/apache/inlong/pull/6055
Fixes #5978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6055: [INLONG-5978][Manager] Add protocol type in cluster nodes
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6055:
URL: https://github.com/apache/inlong/pull/6055#discussion_r983038873
##########
inlong-dashboard/src/pages/Clusters/NodeEditModal.tsx:
##########
@@ -106,6 +106,11 @@ const NodeEditModal: React.FC<NodeEditModalProps> = ({ id, type, clusterId, ...m
max: 65535,
},
},
+ {
+ type: 'input',
Review Comment:
How many protocol types do we support?
Suggested changing the input to select box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6055: [INLONG-5978][Manager] Add protocol type in cluster nodes
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6055:
URL: https://github.com/apache/inlong/pull/6055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org