[GitHub] [wicket] martin-g commented on a change in pull request #482: [WICKET-6935] several minor datatable improvements

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #482:
URL: https://github.com/apache/wicket/pull/482#discussion_r752046172



##########
File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##########
@@ -73,16 +68,16 @@ protected PagingNavigator newPagingNavigator(final String navigatorId,
 	}
 
 	/**
-	 * Factory method used to create the navigator label that will be used by the datatable
+	 * Factory method used to create the navigator label.
 	 * 
 	 * @param navigatorId
 	 *            component id navigator label should be created with
 	 * @param table
-	 *            dataview used by datatable
+	 *            DataTable used by datatable
 	 * @return navigator label that will be used to navigate the data table
 	 * 
 	 */
-	protected WebComponent newNavigatorLabel(final String navigatorId, final DataTable<?, ?> table)
+	protected Component newNavigatorLabel(final String navigatorId, final DataTable<?, ?> table)

Review comment:
       Please do the same for `org.apache.wicket.extensions.ajax.markup.html.AjaxEditableChoiceLabel#newLabel()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org