You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2009/05/29 05:36:45 UTC
[jira] Created: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Change org.apache.hadoop.mapred.jobcontrol to use new api
---------------------------------------------------------
Key: HADOOP-5938
URL: https://issues.apache.org/jira/browse/HADOOP-5938
Project: Hadoop Core
Issue Type: Sub-task
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718788#action_12718788 ]
Jothi Padmanabhan commented on HADOOP-5938:
-------------------------------------------
+1. Changes look good.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719380#action_12719380 ]
Amareshwari Sriramadasu commented on HADOOP-5938:
-------------------------------------------------
Test failures are not related to the patch.
-1 release audit seems wrong. All the newly added files have license header. test-patch on my machine gave a +1.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5938:
--------------------------------------------
Status: Patch Available (was: Open)
test -patch result:
{noformat}
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 15 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
{noformat}
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719068#action_12719068 ]
Hadoop QA commented on HADOOP-5938:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410303/patch-5938-1.txt
against trunk revision 784042.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 release audit. The applied patch generated 493 release audit warnings (more than the trunk's current 492 warnings).
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/496/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/496/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/496/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/496/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/496/console
This message is automatically generated.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5938:
--------------------------------------------
Attachment: patch-5938.txt
Patch modifying org.apache.hadoop.mapred.jobcontrol to use new api.
The new package is named org.apache.hadoop.mapreduce.lib.jobcontrol.
Deprecates the classes org.apache.hadoop.mapred.jobcontrol.Job and org.apache.hadoop.mapred.jobcontrol.JobControl. Corresponding classes in new api are org.apache.hadoop.mapreduce.lib.jobcontrol.ControlledJob and org.apache.hadoop.mapreduce.lib.jobcontrol.JobControl.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5938:
--------------------------------------------
Attachment: patch-5938-1.txt
Patch incorporating review comments.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717014#action_12717014 ]
Hadoop QA commented on HADOOP-5938:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409859/patch-5938.txt
against trunk revision 782083.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 release audit. The applied patch generated 493 release audit warnings (more than the trunk's current 492 warnings).
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/476/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/476/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/476/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/476/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/476/console
This message is automatically generated.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5938:
--------------------------------------------
Status: Open (was: Patch Available)
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5938:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.Thanks Amareshwari!
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717615#action_12717615 ]
Jothi Padmanabhan commented on HADOOP-5938:
-------------------------------------------
Looks good. Some minor comments:
# mapred.jobcontrol.Job, use LOG instead of System.out.println to log the exception.
# Retain the old tests.
# There is some code duplication in the test case. This probably can be refactored.
# You could easily include a test for suspending and resuming JobControl.
# Add a test that verifies that a dependent job cannot be added to a job that is not in the waiting state.
# The utility tests can be moved to test/mapreduce package itself, something in line of UtilsForTests so that other tests can use them too, no?
# Minor nit -- Keep the code wrapped at 80 characters
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5938:
--------------------------------------------
Fix Version/s: 0.21.0
Status: Patch Available (was: Open)
ant test and test-patch passed on my machine.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719586#action_12719586 ]
Hudson commented on HADOOP-5938:
--------------------------------
Integrated in Hadoop-trunk #867 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/867/])
. Change org.apache.hadoop.mapred.jobcontrol to use new mapreduce api. Contributed by Amareshwari Sriramadasu.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938-1.txt, patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5938) Change
org.apache.hadoop.mapred.jobcontrol to use new api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717181#action_12717181 ]
Amareshwari Sriramadasu commented on HADOOP-5938:
-------------------------------------------------
-1 release audit. I dont know why hudson -1 for release audit. All newly added files have license added. I see +1 for release audit when i run test patch on my machine.
-1 contrib tests. Test failure is a known issue on trunk.
> Change org.apache.hadoop.mapred.jobcontrol to use new api
> ---------------------------------------------------------
>
> Key: HADOOP-5938
> URL: https://issues.apache.org/jira/browse/HADOOP-5938
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.