You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Dawid Wysakowicz (Jira)" <ji...@apache.org> on 2019/12/06 10:19:00 UTC

[jira] [Comment Edited] (FLINK-15096) Do not use GlobalJobParameters to pass system configuration

    [ https://issues.apache.org/jira/browse/FLINK-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989607#comment-16989607 ] 

Dawid Wysakowicz edited comment on FLINK-15096 at 12/6/19 10:18 AM:
--------------------------------------------------------------------

If I understand it correctly though FLINK-14514 suggest the opposite. To make no differentiation between system and user parameters and ship everything.

What I am suggesting here to ship only a single key: "pipeline.global-job-parameters" as parameters, nothing more.

See: https://github.com/apache/flink/pull/10431/commits/f2969d974b862d13fe2e2c3d81b8878ca17d70f5


was (Author: dawidwys):
If I understand it correctly though FLINK-14514 suggest the opposite. To make no differentiation between system and user parameters and ship everything.

What I am suggesting here to ship only a single key: "pipeline.global-job-parameters" as parameters, nothing more.

> Do not use GlobalJobParameters to pass system configuration
> -----------------------------------------------------------
>
>                 Key: FLINK-15096
>                 URL: https://issues.apache.org/jira/browse/FLINK-15096
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Python
>    Affects Versions: 1.10.0
>            Reporter: Dawid Wysakowicz
>            Priority: Major
>             Fix For: 1.10.0
>
>
> GlobalJobParameters is a user only configuration that should not be used to ship system specific settings.
> Right now python uses it to ship information about custom archives, files, executables etc.
> A solution would be to pass required configuration when instantiating the operators.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)