You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 01:12:00 UTC
[GitHub] [superset] junlincc edited a comment on pull request #13563: fix: always pass a string as a value to ace editor
junlincc edited a comment on pull request #13563:
URL: https://github.com/apache/superset/pull/13563#issuecomment-797162975
Tested locally and learned something new today, LGTM! Thanks for the fix! 🙏 @eschutho
With FF enabled, I can type and delete in both sql editor and para modal ✅
i can open a new tab with ctrl+t ✅
I am able to type, close, reopen the modal and the data persists ✅
Functionality ✅
https://user-images.githubusercontent.com/67837651/110876681-d5dd1400-828c-11eb-9d8d-13c7993d6ee1.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org