You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lantianyou (via GitHub)" <gi...@apache.org> on 2023/08/01 14:37:04 UTC

[GitHub] [tvm] Lantianyou commented on pull request #15451: [Unity]: fix error on enum

Lantianyou commented on PR #15451:
URL: https://github.com/apache/tvm/pull/15451#issuecomment-1660459926

   Hi @tqchen . Thank you for reviewing my PR. As I am reading the code on web, I found the typescript and eslint configuration can be significantly improved.
   I assume the liner and type checker under web directory is not working for other developers as well, because some of non-recommended code style shows up. like `==`. It is best to use `===` in JavaScript. Those code can run, but the best paractice is to avoid them. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org