You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/18 08:39:34 UTC
[GitHub] [spark] peter-toth opened a new pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
peter-toth opened a new pull request #29802:
URL: https://github.com/apache/spark/pull/29802
### What changes were proposed in this pull request?
This is a follow-up PR to https://github.com/apache/spark/pull/29771 and just adds a new test case.
### Why are the changes needed?
To have better test coverage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694740775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694740314
**[Test build #128870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128870/testReport)** for PR 29802 at commit [`b3751da`](https://github.com/apache/spark/commit/b3751dae395f9527dac27f4f581aa1baf64e3fad).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694880354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694738620
cc @dongjoon-hyun, @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694740314
**[Test build #128870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128870/testReport)** for PR 29802 at commit [`b3751da`](https://github.com/apache/spark/commit/b3751dae395f9527dac27f4f581aa1baf64e3fad).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Add a new test case in catalyst module
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-695122624
late LGTM, thanks, all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694880354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694879045
**[Test build #128870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128870/testReport)** for PR 29802 at commit [`b3751da`](https://github.com/apache/spark/commit/b3751dae395f9527dac27f4f581aa1baf64e3fad).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29802:
URL: https://github.com/apache/spark/pull/29802#issuecomment-694740775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Add a new test case in catalyst module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29802:
URL: https://github.com/apache/spark/pull/29802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org