You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2017/08/06 20:20:32 UTC
[GitHub] flink pull request #4484: Client clean code
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4484
Client clean code
## What is the purpose of the change
Keeping code clean.
## Brief change log
- Move the `args` field to the `CommandLineOptions`(parent class)
- Clean up the test classes in `flink-clients` module
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink client_clean_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4484
----
commit 12c04abee88a2251a4bf69115e90100374546489
Author: zhouhai02 <zh...@meituan.com>
Date: 2017-08-06T17:31:05Z
Move 'args' field to CommandLineOptions
commit 8d8dd4d9c44b027ae1c7431e2d0b74fcd4e6d163
Author: zhouhai02 <zh...@meituan.com>
Date: 2017-08-06T19:01:02Z
cleanup the test classes in flink-clients
commit 5b7e52cb9af8200fe166d19f25deb8a89295201f
Author: zhouhai02 <zh...@meituan.com>
Date: 2017-08-06T19:20:45Z
fix checkstyle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4484
Yes! I hope I didn't discourage you from contributing. It's just that lately we have become careful with purely cosmetic changes because they can introduce subtle bugs and cause overhead when reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4484
Hi @yew1eb,
I'm afraid we should not merge this PR. While I do realise that keeping the code clean is good, I don't think we should just change some parts of the code only to make them look nicer. These changes might look small and harmless but they still require the attention and concentration of a committer to review and they might inadvertently introduce other small bugs.
There also might be changes coming up for the client components, so this code might not be relevant in the near future anymore.
In the future, to avoid doing unnecessary work, please open a Jira and discuss changes before starting the actual work. This way someone with experience in the code base can tell you whether certain changes make sense or not.
I'm very sorry for the inconvenience this causes you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4484
Thank you for your reply.@aljoscha
I am sorry for my first PR. I think I need to read this [Contributing Code](http://flink.apache.org/contribute-code.html).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4484: [FLINK-7376][Client] Cleanup options class and tes...
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---