You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/13 20:03:56 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #24768: Add project_id as a templated variable in two BQ operators

eladkal commented on code in PR #24768:
URL: https://github.com/apache/airflow/pull/24768#discussion_r920456050


##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1853,6 +1853,7 @@ class BigQueryUpsertTableOperator(BaseOperator):
         'dataset_id',
         'table_resource',
         'impersonation_chain',
+        'project_id'

Review Comment:
   ```suggestion
           'project_id',
   ```



##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -2068,6 +2069,7 @@ class BigQueryInsertJobOperator(BaseOperator):
         "configuration",
         "job_id",
         "impersonation_chain",
+        'project_id'

Review Comment:
   ```suggestion
           "project_id",
   ```
   
   These will probably fix the static checks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org