You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/10 12:20:01 UTC

[GitHub] [arrow] praveenbingo commented on a change in pull request #8614: ARROW-10518: [C++][Gandiva] Adding NativeFunction::kCanReturnErrors to cast function in gandiva

praveenbingo commented on a change in pull request #8614:
URL: https://github.com/apache/arrow/pull/8614#discussion_r520519310



##########
File path: cpp/src/gandiva/tests/projector_test.cc
##########
@@ -15,13 +15,13 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include <cmath>
+#include "gandiva/projector.h"

Review comment:
       this reordering looks strange - is this required?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org