[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3376: fix testcase problem: always run fail for zk connect

[GitBox <gi...@apache.org>]

hangc0276 commented on code in PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#discussion_r911583242


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/TestBKConfiguration.java:
##########
@@ -61,9 +61,9 @@ public static ServerConfiguration newServerConfiguration() {
         confReturn.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 4);
         confReturn.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 4);
         /**
-         * if testcase has zk error,just try 0 time for fast running
+         * if testcase has zk error,just try 3 time for fast running
          */
-        confReturn.setZkRetryBackoffMaxRetries(0);
+        confReturn.setZkRetryBackoffMaxRetries(3);

Review Comment:
   Before this PR https://github.com/apache/bookkeeper/pull/2958, the ZK default retry count is `Integer.MAX_VALUE`,   I wonder why not use `Integer.MAX_VALUE` instead of 3? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org