You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/27 20:56:05 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3995: UI bug
fix: Cannot deploy VM from ISO
ustcweizhou opened a new pull request #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995
## Description
<!--- Describe your changes in detail -->
While deploy a vm from ISO on UI, the instance wizard is not working in vm overview step.
this is regression issue of #3271
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606165605
Thanks for noticing this @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez edited a comment on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606113622
The workaround is clicking on Next once this appears. I'll work on a fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606165431
2 x LGTM, manual testing. Regression testing not needed since a simple JS change/not applicable.
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3995: UI bug fix: Cannot
deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606128024
Yes @andrijapanicsb, thanks @ustcweizhou I haven't seen the fix sorry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3995: UI bug fix: Cannot
deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606113622
The workaround is clicking on Next once this appearts. I'll work on a fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606122156
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606123378
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3995: UI bug fix: Cannot
deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-605844418
cc @shwstppr @DaanHoogland @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606132509
Packaging result: ✔centos7 ✔debian. JID-1107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606099910
@nvazquez can you also take a look - the issue is valid, and I would like to make sure the OVF stuff is not broken = then merge it. thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606123851
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606076035
indeed... wow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606121770
the fix is there @nvazquez ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3995: UI bug fix:
Cannot deploy VM from ISO
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3995: UI bug fix: Cannot deploy VM from ISO
URL: https://github.com/apache/cloudstack/pull/3995#issuecomment-606122413
(having some nasty JS overrides in my local lab, so need to build from packages - less effort)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services