You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/18 22:02:00 UTC

[jira] [Work logged] (BEAM-7372) Clean up Python 2 codepaths once Beam no longer supports Python 2.

     [ https://issues.apache.org/jira/browse/BEAM-7372?focusedWorklogId=486403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486403 ]

ASF GitHub Bot logged work on BEAM-7372:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Sep/20 22:01
            Start Date: 18/Sep/20 22:01
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #12872:
URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=h1) Report
   > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/bbda2208a62341c63b9fa75b744b39962b344afd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12872/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12872      +/-   ##
   ==========================================
   - Coverage   82.31%   82.30%   -0.01%     
   ==========================================
     Files         451      451              
     Lines       53874    53874              
   ==========================================
   - Hits        44344    44339       -5     
   - Misses       9530     9535       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/12872/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `88.68% <0.00%> (-1.23%)` | :arrow_down: |
   | [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12872/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `88.80% <0.00%> (-0.54%)` | :arrow_down: |
   | [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12872/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.57% <0.00%> (-0.18%)` | :arrow_down: |
   | [sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12872/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=) | `89.20% <0.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=footer). Last update [bbda220...ad13f01](https://codecov.io/gh/apache/beam/pull/12872?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 486403)
    Remaining Estimate: 0h
            Time Spent: 10m

> Clean up Python 2 codepaths once Beam no longer supports Python 2.
> ------------------------------------------------------------------
>
>                 Key: BEAM-7372
>                 URL: https://issues.apache.org/jira/browse/BEAM-7372
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Priority: P3
>              Labels: P3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are several places in Beam where we branch based on Python version. Once Python 2 is no longer supported, we can remove Py2 parts of the branch.
> To find places to clean up, we can search for "Python 2", "Python 3", "Py2", "sys.version_info", BEAM-8371, etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)