You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/05 20:43:30 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests
Lunderberg opened a new pull request, #12011:
URL: https://github.com/apache/tvm/pull/12011
Previously, the `ci.py` script would execute all C++ unit tests in the `"build"` directory, regardless of the docker image being used. This change allows a caller to specify the build directory to be used by `task_cpp_unittest.sh`, either by the command line or by using the same `TVM_BUILD_PATH environment variable as used by the top-level Makefile, and passes this argument from `ci.py`. To preserve the existing behavior for the pre-commit CI, if no argument is passed and if the `TVM_BUILD_PATH` is undefined, `task_cpp_unittest.sh` defaults to the `"build"` directory.
Python unit tests executed through `ci.py` used the `TVM_LIBRARY_PATH` environment variable, and were not similarly affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12011:
URL: https://github.com/apache/tvm/pull/12011#issuecomment-1175480610
Motivating reason was https://github.com/apache/tvm/pull/11970, where a failure in the C++ tests in `ci_wasm` required multiple steps to reproduce locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12011:
URL: https://github.com/apache/tvm/pull/12011#discussion_r914209498
##########
tests/scripts/ci.py:
##########
@@ -394,7 +396,9 @@ def fn(
# Add named test suites
for option_name, (_, extra_scripts) in options.items():
if kwargs.get(option_name, False):
- scripts += extra_scripts
+ scripts.extend(
+ script.format(name=name, build_dir=build_dir) for script in extra_scripts
Review Comment:
is `name` actually used anywhere?
```suggestion
script.format(build_dir=build_dir) for script in extra_scripts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests
Posted by GitBox <gi...@apache.org>.
masahi merged PR #12011:
URL: https://github.com/apache/tvm/pull/12011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a diff in pull request #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on code in PR #12011:
URL: https://github.com/apache/tvm/pull/12011#discussion_r914212595
##########
tests/scripts/ci.py:
##########
@@ -394,7 +396,9 @@ def fn(
# Add named test suites
for option_name, (_, extra_scripts) in options.items():
if kwargs.get(option_name, False):
- scripts += extra_scripts
+ scripts.extend(
+ script.format(name=name, build_dir=build_dir) for script in extra_scripts
Review Comment:
It currently isn't. I had been thinking that the `task_config_build_{name}.sh` could be similarly handled in the formatting, but it didn't end up being necessary. Updated as suggested, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org