You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2023/12/27 07:51:35 UTC
[PR] [refactor](operator) We dont need OperatorBuild to instantia operatpr [doris]
zhiqiang-hhhh opened a new pull request, #29133:
URL: https://github.com/apache/doris/pull/29133
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870871221
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.69 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17184130471 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29133:
URL: https://github.com/apache/doris/pull/29133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1871671149
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870805709
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuild to instantia operatpr [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870043936
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate DataSinkOperator [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870048602
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate DataSinkOperator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870078363
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 0e4501b305668d7306b050683818ac579de8041b, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4769 4495 4441 4441
q2 363 154 160 154
q3 1477 1326 1258 1258
q4 1136 979 918 918
q5 3181 3157 3162 3157
q6 261 138 137 137
q7 1031 502 485 485
q8 2247 2277 2243 2243
q9 6976 6656 6712 6656
q10 3202 3308 3277 3277
q11 331 207 197 197
q12 349 202 206 202
q13 4557 3810 3778 3778
q14 249 218 217 217
q15 565 514 523 514
q16 446 384 382 382
q17 1033 774 606 606
q18 7091 6752 6853 6752
q19 1641 1638 1666 1638
q20 546 296 293 293
q21 3218 2795 2769 2769
q22 366 295 308 295
Total cold run time: 45035 ms
Total hot run time: 40369 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4399 4380 4387 4380
q2 267 167 171 167
q3 3516 3504 3521 3504
q4 2432 2407 2405 2405
q5 5748 5733 5730 5730
q6 247 127 127 127
q7 2378 1883 1862 1862
q8 3600 3604 3603 3603
q9 9031 8987 9027 8987
q10 3908 3987 4027 3987
q11 490 367 364 364
q12 772 618 611 611
q13 4270 3570 3556 3556
q14 285 248 255 248
q15 571 512 520 512
q16 519 454 457 454
q17 1982 1954 1955 1954
q18 8688 8138 8328 8138
q19 1852 1855 1842 1842
q20 2247 1946 1919 1919
q21 6591 6234 6240 6234
q22 552 476 466 466
Total cold run time: 64345 ms
Total hot run time: 61050 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #29133:
URL: https://github.com/apache/doris/pull/29133#discussion_r1437942030
##########
be/src/pipeline/exec/aggregation_sink_operator.h:
##########
@@ -39,7 +39,7 @@ class AggSinkOperatorBuilder final : public OperatorBuilder<vectorized::Aggregat
bool is_sink() const override { return true; }
};
-class AggSinkOperator final : public StreamingOperator<AggSinkOperatorBuilder> {
Review Comment:
If the operator does not depend on operator builder, then should remove all builders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870845459
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870859979
TeamCity be ut coverage result:
Function Coverage: 36.65% (8588/23433)
Line Coverage: 28.70% (69833/243311)
Region Coverage: 27.69% (36133/130476)
Branch Coverage: 24.41% (18468/75658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b629c631275b017f91854ae7e0a7562886cd64f0_b629c631275b017f91854ae7e0a7562886cd64f0/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #29133:
URL: https://github.com/apache/doris/pull/29133#discussion_r1437942030
##########
be/src/pipeline/exec/aggregation_sink_operator.h:
##########
@@ -39,7 +39,7 @@ class AggSinkOperatorBuilder final : public OperatorBuilder<vectorized::Aggregat
bool is_sink() const override { return true; }
};
-class AggSinkOperator final : public StreamingOperator<AggSinkOperatorBuilder> {
Review Comment:
If the operator does not depend on operator builder, then should remove all builders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870872107
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit b629c631275b017f91854ae7e0a7562886cd64f0, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4982 4701 4627 4627
q2 364 150 159 150
q3 1463 1255 1176 1176
q4 1125 941 939 939
q5 3159 3181 3144 3144
q6 251 127 123 123
q7 1012 484 498 484
q8 2284 2278 2261 2261
q9 6739 6716 6677 6677
q10 3187 3266 3265 3265
q11 335 224 214 214
q12 350 214 205 205
q13 4171 3414 3439 3414
q14 240 212 211 211
q15 572 524 536 524
q16 441 387 391 387
q17 1055 852 651 651
q18 7156 6755 6777 6755
q19 1633 1638 1645 1638
q20 567 285 331 285
q21 3177 2722 2725 2722
q22 362 309 305 305
Total cold run time: 44625 ms
Total hot run time: 40157 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4591 4584 4555 4555
q2 271 165 173 165
q3 3376 3369 3367 3367
q4 2235 2212 2212 2212
q5 5732 5719 5744 5719
q6 242 118 116 116
q7 2395 1834 1896 1834
q8 3615 3621 3611 3611
q9 9064 9065 9003 9003
q10 3802 3883 3892 3883
q11 477 373 375 373
q12 777 621 594 594
q13 3879 3178 3162 3162
q14 281 260 254 254
q15 569 522 519 519
q16 516 473 501 473
q17 1995 1953 1954 1953
q18 8661 8140 8147 8140
q19 1764 1744 1764 1744
q20 2244 1937 1918 1918
q21 6173 5781 5783 5781
q22 544 449 448 448
Total cold run time: 63203 ms
Total hot run time: 59824 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate DataSinkOperator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870082352
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.67 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17183589975 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870845991
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit db7bed0b5dad70271618e42dd889b047641e1162, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4970 4655 4668 4655
q2 382 173 155 155
q3 1488 1267 1176 1176
q4 1138 925 885 885
q5 3174 3167 3170 3167
q6 248 127 126 126
q7 1038 503 484 484
q8 2303 2263 2285 2263
q9 6742 6724 6729 6724
q10 3192 3282 3253 3253
q11 329 226 202 202
q12 356 220 208 208
q13 4136 3461 3430 3430
q14 239 215 217 215
q15 570 522 519 519
q16 446 388 385 385
q17 1055 772 556 556
q18 7098 6780 6891 6780
q19 1622 1650 1640 1640
q20 523 295 290 290
q21 3219 2726 2701 2701
q22 360 303 316 303
Total cold run time: 44628 ms
Total hot run time: 40117 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4592 4590 4574 4574
q2 272 164 170 164
q3 3374 3366 3360 3360
q4 2235 2224 2200 2200
q5 5744 5736 5729 5729
q6 238 120 118 118
q7 2400 1851 1901 1851
q8 3619 3637 3619 3619
q9 9060 8971 8991 8971
q10 3806 3899 3903 3899
q11 503 352 379 352
q12 766 606 599 599
q13 3915 3188 3208 3188
q14 288 261 254 254
q15 579 507 517 507
q16 504 449 475 449
q17 1985 1962 1953 1953
q18 8624 8098 8153 8098
q19 1784 1762 1776 1762
q20 2245 1938 1944 1938
q21 6154 5833 5813 5813
q22 540 461 460 460
Total cold run time: 63227 ms
Total hot run time: 59858 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870840827
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870809423
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870832172
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.79 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17183451965 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate Operator [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1871671135
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuild to instantia operatpr [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870043092
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/7336278355") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 556:
NPM='npm'
^-------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 557:
if ! ${NPM} --version; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^--------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 558:
echo "Error: npm is not found"
^----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 559:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 561:
if [[ -n "${CUSTOM_NPM_REGISTRY}" ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 562:
"${NPM}" config set registry "${CUSTOM_NPM_REGISTRY}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 563:
npm_reg="$("${NPM}" get registry)"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 564:
echo "NPM registry: ${npm_reg}"
^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 567:
echo "Build Frontend UI"
^----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 568:
ui_dist="${DORIS_HOME}/ui/dist"
^-----------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 569:
if [[ -n "${CUSTOM_UI_DIST}" ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 570:
ui_dist="${CUSTOM_UI_DIST}"
^-------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 572:
cd "${DORIS_HOME}/ui"
^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 573:
"${NPM}" cache clean --force
^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 574:
"${NPM}" install --legacy-peer-deps
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 575:
"${NPM}" run build
^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 577:
echo "ui dist: ${ui_dist}"
^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 578:
rm -rf "${DORIS_HOME}/fe/fe-core/src/main/resources/static"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 579:
mkdir -p "${DORIS_HOME}/fe/fe-core/src/main/resources/static"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 580:
cp -r "${ui_dist}"/* "${DORIS_HOME}/fe/fe-core/src/main/resources/static"/
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -537,9 +537,9 @@
-DDORIS_JAVA_HOME="${JAVA_HOME}" \
"${DORIS_HOME}/be"
- "${BUILD_SYSTEM}" -j "${PARALLEL}"
- # 不要 install，这样确保 workspace 的 debug 跟 release 可以使用软连接到不同的二进制
- # "${BUILD_SYSTEM}" install
+ "${BUILD_SYSTEM}" -j "${PARALLEL}"
+ # 不要 install，这样确保 workspace 的 debug 跟 release 可以使用软连接到不同的二进制
+ # "${BUILD_SYSTEM}" install
cd "${DORIS_HOME}"
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate DataSinkOperator [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870072815
TeamCity be ut coverage result:
Function Coverage: 36.59% (8581/23454)
Line Coverage: 28.65% (69741/243437)
Region Coverage: 27.62% (36050/130509)
Branch Coverage: 24.34% (18409/75644)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0e4501b305668d7306b050683818ac579de8041b_0e4501b305668d7306b050683818ac579de8041b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](operator) We dont need OperatorBuilder to instantiate DataSinkOperator [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29133:
URL: https://github.com/apache/doris/pull/29133#issuecomment-1870144834
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org