You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/05/19 14:54:03 UTC
Re: Review Request 59375: Added
REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/
-----------------------------------------------------------
(Updated May 19, 2017, 2:54 p.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
Added REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason.
Bugs: MESOS-6905
https://issues.apache.org/jira/browse/MESOS-6905
Repository: mesos
Description
-------
This gives clear indication about the reason of task status updates
caused by task health update.
Diffs (updated)
-----
include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
src/launcher/default_executor.cpp 5c31f948b5ba470e7c007c39e1c0c903451477e2
src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
src/tests/check_tests.cpp 3607a690c963a84acfb2d3adc6c4a4f148b456d6
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
Diff: https://reviews.apache.org/r/59375/diff/2/
Changes: https://reviews.apache.org/r/59375/diff/1-2/
Testing
-------
Added checks for task status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
Re: Review Request 59375: Added
REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/#review175610
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On May 19, 2017, 9:07 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59375/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 9:07 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-6905
> https://issues.apache.org/jira/browse/MESOS-6905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gives clear indication about the reason of task status updates
> caused by task health update.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
> src/launcher/default_executor.cpp 5c31f948b5ba470e7c007c39e1c0c903451477e2
> src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
> src/tests/check_tests.cpp 3607a690c963a84acfb2d3adc6c4a4f148b456d6
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
>
>
> Diff: https://reviews.apache.org/r/59375/diff/3/
>
>
> Testing
> -------
>
> Added checks for task status updates caused by task health update.
>
> make check (fedora 25, mac os 10.12)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59375: Added
REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/#review175598
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59375]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 19, 2017, 9:07 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59375/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 9:07 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-6905
> https://issues.apache.org/jira/browse/MESOS-6905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gives clear indication about the reason of task status updates
> caused by task health update.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
> src/launcher/default_executor.cpp 5c31f948b5ba470e7c007c39e1c0c903451477e2
> src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
> src/tests/check_tests.cpp 3607a690c963a84acfb2d3adc6c4a4f148b456d6
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
>
>
> Diff: https://reviews.apache.org/r/59375/diff/3/
>
>
> Testing
> -------
>
> Added checks for task status updates caused by task health update.
>
> make check (fedora 25, mac os 10.12)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59375: Added
REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/
-----------------------------------------------------------
(Updated May 19, 2017, 9:07 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-6905
https://issues.apache.org/jira/browse/MESOS-6905
Repository: mesos
Description
-------
This gives clear indication about the reason of task status updates
caused by task health update.
Diffs (updated)
-----
include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
src/launcher/default_executor.cpp 5c31f948b5ba470e7c007c39e1c0c903451477e2
src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
src/tests/check_tests.cpp 3607a690c963a84acfb2d3adc6c4a4f148b456d6
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
Diff: https://reviews.apache.org/r/59375/diff/3/
Changes: https://reviews.apache.org/r/59375/diff/2-3/
Testing
-------
Added checks for task status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
Re: Review Request 59375: Added
REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/#review175526
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59375]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 19, 2017, 2:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59375/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 2:54 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-6905
> https://issues.apache.org/jira/browse/MESOS-6905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gives clear indication about the reason of task status updates
> caused by task health update.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
> src/launcher/default_executor.cpp 5c31f948b5ba470e7c007c39e1c0c903451477e2
> src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
> src/tests/check_tests.cpp 3607a690c963a84acfb2d3adc6c4a4f148b456d6
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
>
>
> Diff: https://reviews.apache.org/r/59375/diff/2/
>
>
> Testing
> -------
>
> Added checks for task status updates caused by task health update.
>
> make check (fedora 25, mac os 10.12)
>
>
> Thanks,
>
> Andrei Budnik
>
>