You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/02/04 06:47:32 UTC

[GitHub] [rocketmq] 873310466 opened a new issue #3812: DefaultMQProducer#sendKernelImpl Line760 tranMsg does not need to check for null when using Boolean.parseBoolean()

873310466 opened a new issue #3812:
URL: https://github.com/apache/rocketmq/issues/3812


   Location: src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java  #sendKernelImpl Line760
   
   ![image](https://user-images.githubusercontent.com/48646884/152484246-3f7a242d-cc19-4338-87dd-ca571a5a6d56.png)
   
   The implementation of parseBoolean is as follows. It internally judge whether it's null.
   ```java
       public static boolean parseBoolean(String s) {
           return ((s != null) && s.equalsIgnoreCase("true"));
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] HScarb commented on issue #3812: DefaultMQProducer#sendKernelImpl Line760 tranMsg does not need to check for null when using Boolean.parseBoolean()

Posted by GitBox <gi...@apache.org>.

HScarb commented on issue #3812:
URL: https://github.com/apache/rocketmq/issues/3812#issuecomment-1029731995


   You can submit a PR to fix it,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Kvicii commented on issue #3812: DefaultMQProducer#sendKernelImpl Line760 tranMsg does not need to check for null when using Boolean.parseBoolean()

Posted by GitBox <gi...@apache.org>.

Kvicii commented on issue #3812:
URL: https://github.com/apache/rocketmq/issues/3812#issuecomment-1029961283


   @LemonFish873310466 
   hi, there.
   please provide rocketmq version, I fixed it on develop branch.[PR-3813](https://github.com/apache/rocketmq/pull/3813)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #3812: DefaultMQProducer#sendKernelImpl Line760 tranMsg does not need to check for null when using Boolean.parseBoolean()

Posted by GitBox <gi...@apache.org>.

duhenglucky closed issue #3812:
URL: https://github.com/apache/rocketmq/issues/3812


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org