You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2005/03/21 17:25:54 UTC
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java
remm 2005/03/21 08:25:53
Modified: catalina/src/share/org/apache/catalina/session
StandardSession.java
Log:
- 34107: I would think the session should still be seen as valid when notifying attributes of unbinding.
- Does this cause regressions or not ?
Revision Changes Path
1.50 +4 -4 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
Index: StandardSession.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- StandardSession.java 22 Nov 2004 16:35:18 -0000 1.49
+++ StandardSession.java 21 Mar 2005 16:25:53 -0000 1.50
@@ -709,14 +709,14 @@
fireSessionEvent(Session.SESSION_DESTROYED_EVENT, null);
}
- // We have completed expire of this session
- expiring = false;
-
// Unbind any objects associated with this session
String keys[] = keys();
for (int i = 0; i < keys.length; i++)
removeAttributeInternal(keys[i], notify);
+ // We have completed expire of this session
+ expiring = false;
+
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <re...@apache.org>
To: <ja...@apache.org>
Sent: Monday, March 21, 2005 8:25 AM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session
StandardSession.java
> remm 2005/03/21 08:25:53
>
> Modified: catalina/src/share/org/apache/catalina/session
> StandardSession.java
> Log:
> - 34107: I would think the session should still be seen as valid when
notifying attributes of unbinding.
> - Does this cause regressions or not ?
>
As promised, a big -1 on this. It breaks the servlet-spec, which
specifically states that the session is invalid.
This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.