You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/16 14:30:46 UTC
[jira] [Commented] (NIFI-1289) Inconsistent bootstrapping of
nifi.properties
[ https://issues.apache.org/jira/browse/NIFI-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059972#comment-15059972 ]
ASF GitHub Bot commented on NIFI-1289:
--------------------------------------
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/142
NIFI-1289 added support for refreshing properties
- Added _getNewInstance()_ operation to NiFiProperties to ensure there is a way to refresh/reload NiFi properties
- Fixed javadocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1289
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit b05d619b828ea3a9f54db0ef87c17ddbfd6af017
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date: 2015-12-16T13:29:33Z
NIFI-1289 added support for refreshing properties
- Added _getNewInstance()_ operation to NiFiProperties to ensure there is a way to refresh/reload NiFi properties
- Fixed javadocs
----
> Inconsistent bootstrapping of nifi.properties
> ---------------------------------------------
>
> Key: NIFI-1289
> URL: https://issues.apache.org/jira/browse/NIFI-1289
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.4.0
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Priority: Minor
> Fix For: 0.5.0
>
>
> NiFiProperties caches the 'instance' of properties in a typical Singleton fashion.
> This creates issues with tests that provide location of nifi.properties for its run when running the entire suite. Fir example when running TestStandardProcessScheduler, the first line in setup method:
> {code}
> System.setProperty("nifi.properties.file.path", "src/test/resources/nifi.properties");
> {code}
> It is absolutely meaningless when such test is ran as part of the suite
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)