You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "aeolus811tw (via GitHub)" <gi...@apache.org> on 2023/05/02 05:52:48 UTC
[GitHub] [flink] aeolus811tw opened a new pull request, #22507: [FLINK-31951][format] Mix schema record source creates corrupt record
aeolus811tw opened a new pull request, #22507:
URL: https://github.com/apache/flink/pull/22507
## What is the purpose of the change
Fix the problem wherer AvroDeserializationSchema class will produce corrupt record after a parsing error was thrown.
## Brief change log
- refactored the Decoder initialization portion to `setupDecoder()` method
- capture the datumreader read error and reinitialize decoder when captured, to avoid future corruption
- added Coordinate as second Avro schema class to test mix schema usage (scenario that encounters unexpected schema record)
- added `generateRandomCoordinate()` method in TestDataGenerator to support unit test
- added `testMixSchemaUsage()` method in AvroDeserializationSchemaTest class as an unit test case for the change
## Verifying this change
This change added `testMixSchemaUsage()` unit test case in AvroDeserializationSchemaTest.java for flink-avro test verification.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: yes
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31951][format] Mix schema record source creates corrupt record [flink]
Posted by "hhktseng (via GitHub)" <gi...@apache.org>.
hhktseng commented on PR #22507:
URL: https://github.com/apache/flink/pull/22507#issuecomment-2776420921
this has been waiting for merge for years
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31951][format] Mix schema record source creates corrupt record [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22507:
URL: https://github.com/apache/flink/pull/22507#issuecomment-2774617534
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31951][format] Mix schema record source creates corrupt record [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #22507: [FLINK-31951][format] Mix schema record source creates corrupt record
URL: https://github.com/apache/flink/pull/22507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22507: [FLINK-31951][format] Mix schema record source creates corrupt record
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22507:
URL: https://github.com/apache/flink/pull/22507#issuecomment-1530921759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fe2f6453fe9490f501b81f60d4279c4915a80104",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fe2f6453fe9490f501b81f60d4279c4915a80104",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe2f6453fe9490f501b81f60d4279c4915a80104 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31951][format] Mix schema record source creates corrupt record [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22507:
URL: https://github.com/apache/flink/pull/22507#issuecomment-2595357435
This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 90 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org