You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by yq...@apache.org on 2023/05/24 02:45:29 UTC

[orc] branch main updated: ORC-1433: [C++] Fix comment in the Vector.hh (#1515)

This is an automated email from the ASF dual-hosted git repository.

yqzhang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new de5831ffb ORC-1433: [C++] Fix comment in the Vector.hh (#1515)
de5831ffb is described below

commit de5831ffbc72e872f61b0afd9683b77bd09c6c61
Author: Gang Wu <us...@gmail.com>
AuthorDate: Wed May 24 11:45:23 2023 +0900

    ORC-1433: [C++] Fix comment in the Vector.hh (#1515)
    
    ### What changes were proposed in this pull request?
    There are some errors in the comment of Vector.hh
    
    ### Why are the changes needed?
    Fix those errors.
    
    ### How was this patch tested?
    Not required.
---
 c++/include/orc/Vector.hh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/c++/include/orc/Vector.hh b/c++/include/orc/Vector.hh
index f6419e93e..0dfe92696 100644
--- a/c++/include/orc/Vector.hh
+++ b/c++/include/orc/Vector.hh
@@ -37,10 +37,10 @@ namespace orc {
    * The base class for each of the column vectors. This class handles
    * the generic attributes such as number of elements, capacity, and
    * notNull vector.
-   * Note: If hasNull is true, the values in the notNull buffer are not required.
+   * Note: If hasNull is false, the values in the notNull buffer are not required.
    * On the writer side, it does not read values from notNull buffer so users are
-   * not expected to write notNull buffer if hasNull is true. On the reader side,
-   * it does not set notNull buffer if hasNull is true, meaning that it is undefined
+   * not expected to write notNull buffer if hasNull is false. On the reader side,
+   * it does not set notNull buffer if hasNull is false, meaning that it is undefined
    * behavior to consume values from notNull buffer in this case by downstream users.
    */
   struct ColumnVectorBatch {