You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "tomberek (JIRA)" <ji...@apache.org> on 2016/08/26 06:15:21 UTC

[jira] [Created] (GUACAMOLE-94) readdir_r is deprecated

tomberek created GUACAMOLE-94:
---------------------------------

             Summary: readdir_r is deprecated
                 Key: GUACAMOLE-94
                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-94
             Project: Guacamole
          Issue Type: Bug
          Components: guacamole-server
    Affects Versions: 0.9.9
            Reporter: tomberek
            Priority: Minor


A function is now deprecated in /src/protocols/rdp/rdp_fs.c:

http://man7.org/linux/man-pages/man3/readdir_r.3.html

I get this during builds (note, I've got a Nix expression building this in a chroot'd sandbox each time):
...
  CC       guac_rdpdr/guacdr_la-rdpdr_fs_service.lo
  CC       guac_rdpdr/guacdr_la-rdpdr_messages.lo
  CC       guac_rdpdr/guacdr_la-rdpdr_printer.lo
  CC       guac_rdpdr/guacdr_la-rdpdr_service.lo
  CC       guacdr_la-rdp_fs.lo
rdp_fs.c: In function 'guac_rdp_fs_read_dir':
rdp_fs.c:563:5: error: 'readdir_r' is deprecated [-Werror=deprecated-declarations]
     if (readdir_r(file->dir, &(file->__dirent), &result))
     ^
In file included from rdp_fs.h:44:0,
                 from rdp_fs.c:25:
/nix/store/8ic0jwg3p5vcwx52k4781n987hmv0bks-glibc-2.24-dev/include/dirent.h:183:12: note: declared here
 extern int readdir_r (DIR *__restrict __dirp,
            ^
cc1: all warnings being treated as errors
make[3]: *** [Makefile:1197: guacdr_la-rdp_fs.lo] Error 1
make[3]: Leaving directory '/tmp/nix-build-guacamole-0.9.9.drv-0/incubator-guacamole-server-6c0862e82da8ee737ee655c7815b1851de6d0488-src/src/protocols/rdp'
make[2]: *** [Makefile:736: all] Error 2
make[2]: Leaving directory '/tmp/nix-build-guacamole-0.9.9.drv-0/incubator-guacamole-server-6c0862e82da8ee737ee655c7815b1851de6d0488-src/src/protocols/rdp'
make[1]: *** [Makefile:474: all-recursive] Error 1
make[1]: Leaving directory '/tmp/nix-build-guacamole-0.9.9.drv-0/incubator-guacamole-server-6c0862e82da8ee737ee655c7815b1851de6d0488-src'
make: *** [Makefile:406: all] Error 2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)