You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 20:21:22 UTC
[GitHub] [airflow] frankcash opened a new issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
frankcash opened a new issue #21566:
URL: https://github.com/apache/airflow/issues/21566
### Apache Airflow Provider(s)
amazon
### Versions of Apache Airflow Providers
3.0.0rc2
### Apache Airflow version
2.2.3 (latest released)
### Operating System
Debian GNU/Linux 11 (bullseye)
### Deployment
Docker-Compose
### Deployment details
_No response_
### What happened
I was working on adding this operator to a DAG and it failed to import due to a lack of a required file
### What you expected to happen
_No response_
### How to reproduce
Add
```
from airflow.providers.amazon.aws.transfers.sql_to_s3 import SqlToS3Operator
```
to a dag
### Anything else
This can be resolved by adding `typing-extensions==4.1.1` to `requirements.txt` when building the project (locally)
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039609475
Ah yeah. Absolutely :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039584017
FYI - There is [typing_compat](https://github.com/apache/airflow/blob/main/airflow/typing_compat.py) that could be used for the `Literal` type import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039584017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
frankcash commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039537580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039609475
Ah yeah. Absolutely :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039599179
Might be worth putting in some sort of CI check for these compat-related imports too. @potiuk WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
frankcash commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039538833
Also looks like the SQS Sensor suffers from a similar issue https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/sensors/sqs.py#L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #21566:
URL: https://github.com/apache/airflow/issues/21566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039518027
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039518027
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on issue #21566: typing_extensions package isn't installed with apache-airflow-providers-amazon causing an issue for SqlToS3Operator
Posted by GitBox <gi...@apache.org>.
frankcash commented on issue #21566:
URL: https://github.com/apache/airflow/issues/21566#issuecomment-1039537580
It looks like as of Python 3.8 this functionality can be achieved by changing the import to
```
from typing import Literal
```
instead of
```
from typing_extensions import Literal
```
but utilizing `typing_extensions` wouldn't break backwards compatibility it would just require a change here https://github.com/apache/airflow/blob/0a6ea572fb5340a904e9cefaa656ac0127b15216/setup.cfg#L140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org