[GitHub] [superset] khrisrichardson opened a new pull request, #23550: feat(helm): optionally set db uri from env

["khrisrichardson (via GitHub)" <gi...@apache.org>]

khrisrichardson opened a new pull request, #23550:
URL: https://github.com/apache/superset/pull/23550

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Allow one to set an alternate sqlalchemy database uri (e.g. - different SQL dialect, mTLS, etc.)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   These commands should yield equivalent results:
   
   ```shell
   helm template \
     supserset helm/superset |
     kubectl apply -f-
   ```
   
   ```shell
   helm template \
     --set supersetNode.connections.db_user="" \
     --set supersetNode.connections.db_pass="" \
     --set supersetNode.connections.db_name="" \
     --set extraSecretEnv.SQLALCHEMY_DATABASE_URI=postgresql+psycopg2://superset:superset@superset-postgresql:5432/superset \
     superset helm/superset |
     kubectl apply -f-
   ```
   
   N.B. - supersetNode connections host & port are not empty strings in the subsequent command so that the TCP test in the init container passes, but nullifying user, pass & name demonstrates that the SQLALCHEMY_DATABASE_URI environment variable overrides the default behavior.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org