You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "funky-eyes (via GitHub)" <gi...@apache.org> on 2025/08/07 07:24:42 UTC

[PR] optimize: remove the 4MB size limit when decompressing with zstd [incubator-seata]

funky-eyes opened a new pull request, #7577:
URL: https://github.com/apache/incubator-seata/pull/7577

   <!--
       Licensed to the Apache Software Foundation (ASF) under one or more
       contributor license agreements.  See the NOTICE file distributed with
       this work for additional information regarding copyright ownership.
       The ASF licenses this file to You under the Apache License, Version 2.0
       (the "License"); you may not use this file except in compliance with
       the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
       
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
       See the License for the specific language governing permissions and
       limitations under the License.
   -->
   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
   - [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
   
   ### Ⅰ. Describe what this PR did
   Other compression methods do not have a maximum compression limit, so the compression limit is removed to maintain consistency.
   ```
   Invalid decompressed size: 4917969, the value of size ranges from 0 to 4194304
   	at org.apache.seata.compressor.zstd.ZstdUtil.decompress(ZstdUtil.java:44)
   ```
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] optimize: remove the 4MB size limit when decompressing with zstd [incubator-seata]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7577:
URL: https://github.com/apache/incubator-seata/pull/7577#issuecomment-3163014919

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7577?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 60.77%. Comparing base ([`92c3d9c`](https://app.codecov.io/gh/apache/incubator-seata/commit/92c3d9c78f4411223a2993e456c958be1eb764b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`088d935`](https://app.codecov.io/gh/apache/incubator-seata/commit/088d93536ad18267b36b1e5e87728ca4a5b155f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##                2.x    #7577   +/-   ##
   =========================================
     Coverage     60.77%   60.77%           
   + Complexity      658      656    -2     
   =========================================
     Files          1308     1308           
     Lines         49434    49432    -2     
     Branches       5811     5810    -1     
   =========================================
   - Hits          30042    30041    -1     
   + Misses        16733    16728    -5     
   - Partials       2659     2663    +4     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7577?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/seata/compressor/zstd/ZstdUtil.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7577?src=pr&el=tree&filepath=compressor%2Fseata-compressor-zstd%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcompressor%2Fzstd%2FZstdUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHJlc3Nvci9zZWF0YS1jb21wcmVzc29yLXpzdGQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlYXRhL2NvbXByZXNzb3IvenN0ZC9ac3RkVXRpbC5qYXZh) | `90.00% <ø> (+6.66%)` | :arrow_up: |
   
   ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7577/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/7577/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/7577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] optimize: remove the 4MB size limit when decompressing with zstd [incubator-seata]

Posted by "xjlgod (via GitHub)" <gi...@apache.org>.
xjlgod commented on code in PR #7577:
URL: https://github.com/apache/incubator-seata/pull/7577#discussion_r2265105063


##########
compressor/seata-compressor-zstd/src/main/java/org/apache/seata/compressor/zstd/ZstdUtil.java:
##########
@@ -24,26 +24,18 @@
  */
 public class ZstdUtil {
 
-    public static final int MAX_COMPRESSED_SIZE = 4 * 1024 * 1024;

Review Comment:
   Why we have this limit before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] optimize: remove the 4MB size limit when decompressing with zstd [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7577:
URL: https://github.com/apache/incubator-seata/pull/7577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org