You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/12 22:15:40 UTC
[GitHub] [trafficcontrol] guzzijason opened a new issue #5739: Login failure loop in v5.1.0 go v3-client
guzzijason opened a new issue #5739:
URL: https://github.com/apache/trafficcontrol/issues/5739
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Control Client
- Traffic Ops
## Current behavior:
When building go client applications with the TC v5.1.0 v3-client library, we have observed that a login failure (such as resulting from passing incorrect login credentials) results in a looping condition, where a steady stream of login attempts are made against TO API.
## Expected behavior:
When invalid login credentials are used, the login attempt should fail immediately, without a apparent retry loop.
## Minimal reproduction of the problem with instructions:
Build a client app using `github.com/apache/trafficcontrol v5.1.0+incompatible`.
Pass invalid login credentials to that app.
## Anything else:
Confirmed that building with `github.com/apache/trafficcontrol v5.0.0+incompatible` does not reproduce the problem.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on issue #5739: Login failure loop in v5.1.0 go v3-client
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5739:
URL: https://github.com/apache/trafficcontrol/issues/5739#issuecomment-818279673
For whoever fixes this:
`request()` is calling `login()` if the 1st attempt returned 401. `login()` eventually makes its way back to `request()`, which gets another 401, causing it to call `login()` again, getting stuck in infinite recursion. Instead of calling `login()`, we should probably make a "raw" login request instead of calling `login()` which also adds in all the version-retrying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed issue #5739: Login failure loop in v5.1.0 go v3-client
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #5739:
URL: https://github.com/apache/trafficcontrol/issues/5739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on issue #5739: Login failure loop in v5.1.0 go v3-client
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on issue #5739:
URL: https://github.com/apache/trafficcontrol/issues/5739#issuecomment-818353955
I can take this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org