[jira] [Commented] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860321#comment-15860321 ] 

ASF subversion and git services commented on GEODE-2324:
--------------------------------------------------------

Commit d73ec978476ec4bf835c38d1713e14b48324515f in geode's branch refs/heads/develop from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d73ec97 ]

[GEODE-2324] keep private variables private.

* Update AcceptorImplDUnit test,
* Refactor AcceptorImpl.close into multiple methods.
* Remove a commented-out method.


> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-2324
>                 URL: https://issues.apache.org/jira/browse/GEODE-2324
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>    Affects Versions: 1.0.0-incubating
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
>
> In {{AcceptorImpl.close()}}, the call to {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which case neither {pool} nor {{hsPool}} or anything else that comes after is properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued (for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)