You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Matteo Bertozzi (JIRA)" <ji...@apache.org> on 2012/05/21 22:52:40 UTC

[jira] [Created] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Matteo Bertozzi created HBASE-6062:
--------------------------------------

             Summary: preCheckAndPut/Delete() checks for READ when also a WRITE is performed
                 Key: HBASE-6062
                 URL: https://issues.apache.org/jira/browse/HBASE-6062
             Project: HBase
          Issue Type: Sub-task
    Affects Versions: 0.94.0, 0.92.1, 0.96.0
            Reporter: Matteo Bertozzi
            Assignee: Matteo Bertozzi
             Fix For: 0.92.2, 0.96.0, 0.94.1


preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
for me checking for WRITE permission is the right thing... 
what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280534#comment-13280534 ] 

Hadoop QA commented on HBASE-6062:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528497/HBASE-6062-v0.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.coprocessor.TestMasterObserver
                  org.apache.hadoop.hbase.replication.TestReplication
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.replication.TestMasterReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1949//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1949//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1949//console

This message is automatically generated.
                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-v0.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286221#comment-13286221 ] 

Hudson commented on HBASE-6062:
-------------------------------

Integrated in HBase-0.94 #237 (See [https://builds.apache.org/job/HBase-0.94/237/])
    HBASE-6062 preCheckAndPut/Delete() checks for READ when also a WRITE is performed (Revision 1344487)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/branches/0.94/security/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java

                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl closed HBASE-6062.
--------------------------------

    
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286199#comment-13286199 ] 

Hudson commented on HBASE-6062:
-------------------------------

Integrated in HBase-TRUNK #2959 (See [https://builds.apache.org/job/HBase-TRUNK/2959/])
    HBASE-6062 preCheckAndPut/Delete() checks for READ when also a WRITE is performed (Revision 1344486)

     Result = FAILURE
stack : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java

                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Bertozzi updated HBASE-6062:
-----------------------------------

    Attachment: HBASE-6062-v1.patch
                HBASE-6062-0.92.patch

Patch available for trunk and 0.92 (that applies also to 0.94)

Require permission for both READ and WRITE
and added a testReadWrite() to check checkAndDelete() and checkAndPut() methods
                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287243#comment-13287243 ] 

Hudson commented on HBASE-6062:
-------------------------------

Integrated in HBase-0.92-security #109 (See [https://builds.apache.org/job/HBase-0.92-security/109/])
    HBASE-6062 preCheckAndPut/Delete() checks for READ when also a WRITE is performed (Revision 1344488)

     Result = SUCCESS
stack : 
Files : 
* /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/branches/0.92/security/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java

                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6062:
-------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.96.0)
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Committed 0.92, 0.94 and trunk.  Thanks for the patch Matteo.
                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285953#comment-13285953 ] 

stack commented on HBASE-6062:
------------------------------

@Matteo Want to update the patch as Andrew suggests? Thanks.
                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-v0.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286112#comment-13286112 ] 

Hadoop QA commented on HBASE-6062:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530268/HBASE-6062-v1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2064//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2064//console

This message is automatically generated.
                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286237#comment-13286237 ] 

Hudson commented on HBASE-6062:
-------------------------------

Integrated in HBase-0.92 #435 (See [https://builds.apache.org/job/HBase-0.92/435/])
    HBASE-6062 preCheckAndPut/Delete() checks for READ when also a WRITE is performed (Revision 1344488)

     Result = SUCCESS
stack : 
Files : 
* /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/branches/0.92/security/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java

                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286214#comment-13286214 ] 

Hudson commented on HBASE-6062:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/])
    HBASE-6062 preCheckAndPut/Delete() checks for READ when also a WRITE is performed (Revision 1344486)

     Result = FAILURE
stack : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java

                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Bertozzi updated HBASE-6062:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.94.0, 0.92.1, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-v0.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Bertozzi updated HBASE-6062:
-----------------------------------

    Attachment: HBASE-6062-v0.patch
    
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-v0.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Laxman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Laxman updated HBASE-6062:
--------------------------

    Component/s: security
    
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-v0.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287167#comment-13287167 ] 

Hudson commented on HBASE-6062:
-------------------------------

Integrated in HBase-0.94-security #33 (See [https://builds.apache.org/job/HBase-0.94-security/33/])
    HBASE-6062 preCheckAndPut/Delete() checks for READ when also a WRITE is performed (Revision 1344487)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/branches/0.94/security/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java

                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6062-0.92.patch, HBASE-6062-v0.patch, HBASE-6062-v1.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6062) preCheckAndPut/Delete() checks for READ when also a WRITE is performed

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280594#comment-13280594 ] 

Andrew Purtell commented on HBASE-6062:
---------------------------------------

Patch looks good but please make sure TestAccessController includes tests for the change. 
                
> preCheckAndPut/Delete() checks for READ when also a WRITE is performed
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6062
>                 URL: https://issues.apache.org/jira/browse/HBASE-6062
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>              Labels: acl, security
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6062-v0.patch
>
>
> preCheckAndPut() and preCheckAndDelete() checks for READ when they also want to WRITE... 
> for me checking for WRITE permission is the right thing... 
> what do you say about that? keep READ, replace with WRITE?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira