You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/20 06:31:55 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9853: Adding Emotion ThemeProviders for all React apps
rusackas opened a new pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In order to start moving things more toward using CSS-in-JS (with Emotion) this PR adds ThemeProviders to all of the React apps in the codebase. Maybe one day we can whittle down the number of these apps, but for now, they should all work the same, so I'm just propagating the pattern here.
In particular, the Explore and Dashboard apps _will_ need it, so the theme can be used in viz plugins reliably.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631583595
@suddjian could use a sanity check review, if you don't mind :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.99% -0.15%
==========================================
Files 589 588 -1
Lines 30797 30610 -187
Branches 3241 3238 -3
==========================================
- Hits 21907 21731 -176
+ Misses 8779 8768 -11
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.04% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `71.01% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.86% -0.28%
==========================================
Files 589 588 -1
Lines 30797 30610 -187
Branches 3241 3238 -3
==========================================
- Hits 21907 21691 -216
- Misses 8779 8808 +29
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.04% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #9853: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#discussion_r427771002
##########
File path: superset-frontend/src/explore/App.jsx
##########
@@ -32,10 +34,12 @@ setupPlugins();
const App = ({ store }) => (
<Provider store={store}>
- <div>
- <ExploreViewContainer />
- <ToastPresenter />
- </div>
+ <ThemeProvider theme={supersetTheme}>
+ <div>
Review comment:
This div doesn't look like it has any business being here, but I don't want to be wrong when it's beside the point of this PR ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
+ Coverage 71.13% 71.27% +0.13%
==========================================
Files 589 184 -405
Lines 30797 18051 -12746
Branches 3241 0 -3241
==========================================
- Hits 21907 12865 -9042
+ Misses 8779 5186 -3593
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.27% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/components/CodeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvZGVNb2RhbC5qc3g=) | | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | | |
| [...ontend/src/dashboard/util/getChartIdsFromLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0SWRzRnJvbUxheW91dC5qcw==) | | |
| [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | | |
| ... and [389 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...2bf8cc2](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `11.83%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
===========================================
- Coverage 71.13% 59.29% -11.84%
===========================================
Files 589 404 -185
Lines 30797 12742 -18055
Branches 3241 3238 -3
===========================================
- Hits 21907 7556 -14351
+ Misses 8779 4999 -3780
- Partials 111 187 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `56.60% <ø> (-35.85%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [331 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.91% -0.22%
==========================================
Files 589 184 -405
Lines 30797 17868 -12929
Branches 3241 0 -3241
==========================================
- Hits 21907 12671 -9236
+ Misses 8779 5197 -3582
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.91% <ø> (-0.36%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-3.14%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `67.74% <0.00%> (-1.96%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| ... and [427 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...9717229](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
+ Coverage 71.13% 71.20% +0.07%
==========================================
Files 589 184 -405
Lines 30797 18051 -12746
Branches 3241 0 -3241
==========================================
- Hits 21907 12853 -9054
+ Misses 8779 5198 -3581
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.20% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.80% <0.00%> (-0.22%)` | :arrow_down: |
| [...t-frontend/src/SqlLab/components/ColumnElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQuanN4) | | |
| [...uperset-frontend/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Nob3dTUUwuanN4) | | |
| [...rset-frontend/src/dashboard/util/componentTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLmpz) | | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | | |
| ... and [392 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...2bf8cc2](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.66% -0.48%
==========================================
Files 589 588 -1
Lines 30797 30610 -187
Branches 3241 3238 -3
==========================================
- Hits 21907 21630 -277
- Misses 8779 8862 +83
- Partials 111 118 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.26% <ø> (-0.77%)` | :arrow_down: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
+ Coverage 71.13% 71.27% +0.13%
==========================================
Files 589 184 -405
Lines 30797 18051 -12746
Branches 3241 0 -3241
==========================================
- Hits 21907 12865 -9042
+ Misses 8779 5186 -3593
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.27% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/components/CodeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvZGVNb2RhbC5qc3g=) | | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | | |
| [...ontend/src/dashboard/util/getChartIdsFromLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0SWRzRnJvbUxheW91dC5qcw==) | | |
| [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | | |
| ... and [389 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...9717229](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.48% -0.66%
==========================================
Files 589 404 -185
Lines 30797 12742 -18055
Branches 3241 3238 -3
==========================================
- Hits 21907 8981 -12926
+ Misses 8779 3643 -5136
- Partials 111 118 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.26% <ø> (-0.77%)` | :arrow_down: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.99% -0.15%
==========================================
Files 589 588 -1
Lines 30797 30610 -187
Branches 3241 3238 -3
==========================================
- Hits 21907 21731 -176
+ Misses 8779 8768 -11
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.04% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `71.01% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
=======================================
Coverage 71.13% 71.14%
=======================================
Files 589 588 -1
Lines 30797 30793 -4
Branches 3241 3238 -3
=======================================
Hits 21907 21907
+ Misses 8779 8775 -4
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.04% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `71.27% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Markup.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXJrdXAuanM=) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `13.33% <0.00%> (+0.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
+ Coverage 71.13% 71.27% +0.13%
==========================================
Files 589 184 -405
Lines 30797 18051 -12746
Branches 3241 0 -3241
==========================================
- Hits 21907 12865 -9042
+ Misses 8779 5186 -3593
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.27% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | | |
| [...-frontend/src/SqlLab/reducers/localStorageUsage.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9sb2NhbFN0b3JhZ2VVc2FnZS5qcw==) | | |
| [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | | |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | | |
| [...nents/gridComponents/new/DraggableNewComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9EcmFnZ2FibGVOZXdDb21wb25lbnQuanN4) | | |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | | |
| [superset-frontend/src/utils/hostNamesConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2hvc3ROYW1lc0NvbmZpZy5qcw==) | | |
| [superset-frontend/src/profile/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAuanN4) | | |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | | |
| ... and [389 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...9717229](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.79% -0.35%
==========================================
Files 589 184 -405
Lines 30797 17868 -12929
Branches 3241 0 -3241
==========================================
- Hits 21907 12649 -9258
+ Misses 8779 5219 -3560
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-3.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| ... and [430 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...2bf8cc2](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9853: feat: Adding Emotion ThemeProviders for all React apps
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9853:
URL: https://github.com/apache/incubator-superset/pull/9853#issuecomment-631269001
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=h1) Report
> Merging [#9853](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81ab8dd8b46f7291171e674cd48d498c1efde409&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9853 +/- ##
==========================================
- Coverage 71.13% 70.99% -0.14%
==========================================
Files 589 588 -1
Lines 30797 30610 -187
Branches 3241 3238 -3
==========================================
- Hits 21907 21732 -175
+ Misses 8779 8767 -12
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.04% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `59.29% <0.00%> (+0.01%)` | :arrow_up: |
| #python | `71.02% <ø> (-0.25%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `92.45% <ø> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/incubator-superset/pull/9853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=footer). Last update [81ab8dd...b14b8c1](https://codecov.io/gh/apache/incubator-superset/pull/9853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org