You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/08/31 13:18:05 UTC
[GitHub] flink pull request #4629: [hotfix][table] Fix bug of testAggregateFunctionOp...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4629
[hotfix][table] Fix bug of testAggregateFunctionOperandTypeCheck
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
`UserDefinedFunctionUtils#signaturesToString` does not have the same result for AGG with multiple signatures in different JVMs， So In this PR. hot fix testAggregateFunctionOperandTypeCheck by using the AGG with a single signature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4629.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4629
----
commit c3d9cb37248fba00553e532601db9ef067c81526
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-08-31T12:25:44Z
Hotfix bug of testAggregateFunctionOperandTypeCheck
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4629: [hotfix][table] Fix bug of testAggregateFunctionOperandTy...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4629
Thanks for the hotfix, will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4629: [hotfix][table] Fix bug of testAggregateFunctionOp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4629
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---