You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2011/11/02 01:57:54 UTC
Re: Review Request: Remove unused configuration in shindig.properties for
proxy and concat urls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/#review3005
-----------------------------------------------------------
Stanton I am having a problem applying the patch, could you update and regenerate the patch?
- Ryan
On 2011-10-31 12:28:02, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2640/
> -----------------------------------------------------------
>
> (Updated 2011-10-31 12:28:02)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
>
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&
>
>
> This addresses bug SHINDIG-1654.
> https://issues.apache.org/jira/browse/SHINDIG-1654
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346
>
> Diff: https://reviews.apache.org/r/2640/diff
>
>
> Testing
> -------
>
> Build/Junit passed
>
>
> Thanks,
>
> Stanton
>
>
Re: Review Request: Remove unused configuration in shindig.properties for
proxy and concat urls
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-11-02 00:57:54, Ryan Baxter wrote:
> > Stanton I am having a problem applying the patch, could you update and regenerate the patch?
NM looks like Henry committed this :)
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/#review3005
-----------------------------------------------------------
On 2011-10-31 12:28:02, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2640/
> -----------------------------------------------------------
>
> (Updated 2011-10-31 12:28:02)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
>
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&
>
>
> This addresses bug SHINDIG-1654.
> https://issues.apache.org/jira/browse/SHINDIG-1654
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346
>
> Diff: https://reviews.apache.org/r/2640/diff
>
>
> Testing
> -------
>
> Build/Junit passed
>
>
> Thanks,
>
> Stanton
>
>