You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/10/07 02:31:21 UTC

Re: [PR] [SPARK-45370][PYTHON][TESTS] Fix python test when ansi mode enabled [spark]

panbingkun commented on code in PR #43168:
URL: https://github.com/apache/spark/pull/43168#discussion_r1349439434


##########
python/pyspark/sql/functions.py:
##########
@@ -11738,15 +11738,29 @@ def create_map(
 
     >>> from pyspark.sql import functions as sf
     >>> df = spark.createDataFrame([("Alice", 2, "female"),
-    ...                             ("Bob", 5, "male")], ("name", "age", "gender"))
+    ...     ("Bob", 5, "male")], ("name", "age", "gender"))

Review Comment:
   Because our Python style uses 4 spaces for indentation, I suggest maintaining consistent indentation in the same code snippet (Existing examples and newly added examples.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org