[GitHub] [lucene] gautamworah96 commented on a change in pull request #175: LUCENE-9990: gradle7 support

[GitBox <gi...@apache.org>]

gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647040440



##########
File path: gradle/wrapper/gradle-wrapper.jar.version
##########
@@ -1 +1 @@
-6.8.3
+7.0.2

Review comment:
       I checked https://services.gradle.org/distributions/ and the SHA256 of the gradle-7.0.2-wrapper.jar.sha256 has remained the same. It was the same for the 6.6.1 to 6.8.3 transition as well

##########
File path: gradle/java/javac.gradle
##########
@@ -16,6 +16,15 @@
  */
 
 // Configure Java project defaults.
+java {
+  toolchain {
+    languageVersion = JavaLanguageVersion.of(11)
+  }
+}
+
+tasks.withType( JavaCompile ).configureEach {

Review comment:
       Sure. gradle/hacks makes sense. I'll also follow up on the ticket to see if there is a better way to solve this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org