You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ivan Zuzak (JIRA)" <ji...@apache.org> on 2009/10/19 17:04:59 UTC

[jira] Created: (SHINDIG-1198) Wrong construction of URIs in gadgets.rpc feature

Wrong construction of URIs in gadgets.rpc feature
-------------------------------------------------

                 Key: SHINDIG-1198
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1198
             Project: Shindig
          Issue Type: Bug
          Components: Javascript 
            Reporter: Ivan Zuzak
            Priority: Minor
         Attachments: fix-rpc-getOrigin-colon-bug.patch

In rpc.js, getOrigin method, URIs are in some places constructed using window.location.protocol + ":" in order to get "http:" as a start of a full URI. This is wrong since window.location.protocol already ends with ":", so the resulting URIs start with "http::".

I've attached a patch which removes the extra colons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHINDIG-1198) Wrong construction of URIs in gadgets.rpc feature

Posted by "Ivan Zuzak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Zuzak updated SHINDIG-1198:
--------------------------------

    Attachment: fix-rpc-getOrigin-colon-bug.patch

> Wrong construction of URIs in gadgets.rpc feature
> -------------------------------------------------
>
>                 Key: SHINDIG-1198
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1198
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>            Reporter: Ivan Zuzak
>            Priority: Minor
>         Attachments: fix-rpc-getOrigin-colon-bug.patch
>
>
> In rpc.js, getOrigin method, URIs are in some places constructed using window.location.protocol + ":" in order to get "http:" as a start of a full URI. This is wrong since window.location.protocol already ends with ":", so the resulting URIs start with "http::".
> I've attached a patch which removes the extra colons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-1198) Wrong construction of URIs in gadgets.rpc feature

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1198.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1-BETA4

Patch applied - Thanks!

> Wrong construction of URIs in gadgets.rpc feature
> -------------------------------------------------
>
>                 Key: SHINDIG-1198
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1198
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>            Reporter: Ivan Zuzak
>            Priority: Minor
>             Fix For: 1.1-BETA4
>
>         Attachments: fix-rpc-getOrigin-colon-bug.patch
>
>
> In rpc.js, getOrigin method, URIs are in some places constructed using window.location.protocol + ":" in order to get "http:" as a start of a full URI. This is wrong since window.location.protocol already ends with ":", so the resulting URIs start with "http::".
> I've attached a patch which removes the extra colons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.