You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/05 10:49:39 UTC
[GitHub] [incubator-doris] WingsGo opened a new pull request #2660:
[Build]Make set target arch universal
WingsGo opened a new pull request #2660: [Build]Make set target arch universal
URL: https://github.com/apache/incubator-doris/pull/2660
There is a problem that if the compile computer language is not en, for example zh_CN.UTF-8, the variable CMAKE_BUILD_TARGET_ARCH will be empty.So use `uname -m` to set CMAKE_BUILD_TARGET_ARCH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2660: [Build]Make set
target arch universal
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2660: [Build]Make set target arch universal
URL: https://github.com/apache/incubator-doris/pull/2660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2660:
[Build]Make set target arch universal
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2660: [Build]Make set target arch universal
URL: https://github.com/apache/incubator-doris/pull/2660#discussion_r363171185
##########
File path: be/CMakeLists.txt
##########
@@ -40,7 +40,7 @@ string(TOUPPER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)
message(STATUS "Build type is ${CMAKE_BUILD_TYPE}")
# set CMAKE_BUILD_TARGET_ARCH
-execute_process(COMMAND bash "-c" "lscpu | grep 'Architecture' | awk '{print $2}'"
+execute_process(COMMAND bash "-c" "uname -m"
Review comment:
Better to leave a comment to describe the origin method's problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org