[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4137: Adding VPN options for IKE version and IKE split connections.

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#discussion_r569763820



##########
File path: setup/db/create-schema.sql
##########
@@ -2280,6 +2280,8 @@ CREATE TABLE `cloud`.`s2s_customer_gateway` (
   `domain_id` bigint unsigned NOT NULL,
   `account_id` bigint unsigned NOT NULL,
   `removed` datetime COMMENT 'date removed if not null',
+  `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
+  `split_connections` int(1) NOT NULL DEFAULT 0,

Review comment:
       @ggoodrich-ipp 
   this affects only fresh installation.
   
   need to add sqls in engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
   ```
   alter table s2s_customer_gateway add column `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2';
   alter table s2s_customer_gateway add column `split_connections` int(1) NOT NULL DEFAULT 0;
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org