You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2021/01/11 08:21:47 UTC
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #391: [TUBEMQ-501] Adjust max message size check logic
gosonzhang opened a new pull request #391:
URL: https://github.com/apache/incubator-tubemq/pull/391
1. Adjust the processing logic of Producer, Broker, and Master, and increase the maximum message length to dynamically check and process;
2. Adjust the unit of the maximum message packet length setting value from byte to MB
3. Optimize some implementation logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io commented on pull request #391: [TUBEMQ-501] Adjust max message size check logic
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #391:
URL: https://github.com/apache/incubator-tubemq/pull/391#issuecomment-757859654
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=h1) Report
> Merging [#391](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=desc) (220a331) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/fb70aa8577551527d86a4b0c38a761751a5b7e78?el=desc) (fb70aa8) will **increase** coverage by `0.02%`.
> The diff coverage is `0.30%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #391 +/- ##
===========================================
+ Coverage 7.44% 7.46% +0.02%
- Complexity 469 473 +4
===========================================
Files 267 268 +1
Lines 29306 29438 +132
Branches 4834 4857 +23
===========================================
+ Hits 2181 2197 +16
- Misses 26647 26766 +119
+ Partials 478 475 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/tubemq/client/producer/AllowedSetting.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9BbGxvd2VkU2V0dGluZy5qYXZh) | `28.57% <0.00%> (+28.57%)` | `1.00 <0.00> (+1.00)` | |
| [.../tubemq/client/producer/SimpleMessageProducer.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9TaW1wbGVNZXNzYWdlUHJvZHVjZXIuamF2YQ==) | `13.06% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...ava/org/apache/tubemq/corebase/TBaseConstants.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9UQmFzZUNvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/tubemq/corebase/utils/MixedUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9NaXhlZFV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/tubemq/corebase/utils/SettingValidUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9TZXR0aW5nVmFsaWRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/tubemq/corerpc/RpcConstants.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlcnBjL1JwY0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/tubemq/server/broker/BrokerServiceServer.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvQnJva2VyU2VydmljZVNlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/tubemq/server/broker/TubeBroker.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvVHViZUJyb2tlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mq/server/broker/metadata/ClusterConfigHolder.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvbWV0YWRhdGEvQ2x1c3RlckNvbmZpZ0hvbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/tubemq/server/broker/msgstore/MessageStore.java](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvbXNnc3RvcmUvTWVzc2FnZVN0b3JlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-tubemq/pull/391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=footer). Last update [fb70aa8...220a331](https://codecov.io/gh/apache/incubator-tubemq/pull/391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #391: [TUBEMQ-501] Adjust max message size check logic
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #391:
URL: https://github.com/apache/incubator-tubemq/pull/391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org