You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tooling.apache.org by "sbp (via GitHub)" <gi...@apache.org> on 2026/09/30 19:52:06 UTC

[I] Verify ASVS 13.3.4 requirements for signing-key rotation (tooling-trusted-releases)

sbp opened a new issue, #1681:
URL: https://github.com/apache/tooling-trusted-releases/issues/1681

   The JWT signing key (`secrets/generated/jwt_secret_key.txt`) and the session signing key (`secrets/generated/apptoken.txt`) are long-lived secrets generated once at first startup and persisted indefinitely. While a manual rotation function exists (`rotate_jwt_signing_key()` in `atr/storage/writers/tokens.py`), no automatic rotation schedule, expiration timestamp, or periodic rotation task is implemented.
   
   ```python
   # atr/server.py - _register_recurrent_tasks() (no key rotation task present)
   async def _register_recurrent_tasks() -> None:
       """Schedule recurring tasks"""
       await tasks.clear_scheduled()
       maintenance = await tasks.run_maintenance(asf_uid=constants.SYSTEM_SERVICE_UID, schedule_next=True)
       log.info(f"Scheduled maintenance with ID {maintenance.id}")
       await tasks.schedule_next(
           constants.SYSTEM_SERVICE_UID, tasks.INTEGRITY_CHECK_INTERVAL_SECONDS, tasks.integrity_check
       )
       # Start other tasks 5 min after server start
       await asyncio.sleep(300)
       try:
           await asyncio.sleep(60)
           metadata = await tasks.metadata_update(asf_uid=constants.SYSTEM_SERVICE_UID, schedule_next=True)
           ...
       except Exception as e:
           log.exception(f"Failed to schedule recurrent tasks with ID {e!s}")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Verify ASVS 13.3.4 key-rotation requirements (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1681:
URL: https://github.com/apache/tooling-trusted-releases/issues/1681#issuecomment-6175510494

   It does not require automatic rotation, but it does require at least a documented manual rotation policy at L3.
   
   Resolved by a9a9209eed3ec4fb43fa39475b449e70bb9ba1a1, which requires rotation every two years.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Verify ASVS 13.3.4 key-rotation requirements (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #1681: Verify ASVS 13.3.4 key-rotation requirements
URL: https://github.com/apache/tooling-trusted-releases/issues/1681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Verify ASVS 13.3.4 requirements for signing-key rotation (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1681:
URL: https://github.com/apache/tooling-trusted-releases/issues/1681#issuecomment-5918540223

   ASVS triage: Verify whether ASVS 13.3.4 requires automatic rotation of these signing keys before deciding on implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org