You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/07 18:38:07 UTC
[GitHub] flink pull request #4494: [FLINK-7026] Introduce flink-shaded-asm-5
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4494
[FLINK-7026] Introduce flink-shaded-asm-5
## What is the purpose of the change
This PR integrates the shaded asm dependency from flink-shaded. Basically, replace all usages of asm with the shaded asm dependeny and remove all traces of the original dependency.
## Brief change log
- replace all asm dependencies with flink-shaded-asm
- replace all asm imports
- modify illegal import checkstyle rule to forbid unshaded asm imports
- add check in travis watchdog that no unshaded asm classes are present in flink-dist
## Verifying this change
- check that compilation works
- check artifacts for inclusion of shaded asm
- check artifacts for exclusion of unshaded asm
- check that we are not exposing a vanilla asm dependency with maven
- start a cluster and run some examples
- check that the web interface still works
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4494
----
commit 89083883e83d1cc5c558fda35e87ceeca9607104
Author: zentol <ch...@apache.org>
Date: 2017-06-28T11:23:53Z
[FLINK-7026] Introduce flink-shaded-asm-5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4494
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4494
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4494
Thank your for the review @greghogan . I made 2 more changes to the kinesis/shaded-curator poms; they were including/relocating asm in their shade-plugin configuration even though neither appears to have a dependency on asm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4494
@zentol I think it should be safe to remove that asm relocation (for Kinesis, as far as I'm aware of).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4494: [FLINK-7026] Introduce flink-shaded-asm-5
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---