You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "markrmiller (via GitHub)" <gi...@apache.org> on 2023/10/03 07:27:08 UTC
[PR] Add the requet back to the queue on fail, not just the last record. [solr-sandbox]
markrmiller opened a new pull request, #75:
URL: https://github.com/apache/solr-sandbox/pull/75
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Add the requet back to the queue on fail, not just the last record. [solr-sandbox]
Posted by "markrmiller (via GitHub)" <gi...@apache.org>.
markrmiller commented on code in PR #75:
URL: https://github.com/apache/solr-sandbox/pull/75#discussion_r1344802109
##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -329,7 +329,7 @@ void processResult(ConsumerRecord<String,MirroredSolrRequest> record, IQueueHand
log.trace("result=failed-resubmit");
}
metrics.counter("failed-resubmit").inc();
- kafkaMirroringSink.submit(record.value());
+ kafkaMirroringSink.submit(result.newItem());
Review Comment:
I honestly have no clue. I started on this from Anshum's original dump that he extracted from some older code that did other things and integrated with other components. I don't understand much about the naming in that class, and since I haven't really had to touch before, it's just kind of survived. I'll make sure to refactor it in a cleanup issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Add the requet back to the queue on fail, not just the last record. [solr-sandbox]
Posted by "markrmiller (via GitHub)" <gi...@apache.org>.
markrmiller merged PR #75:
URL: https://github.com/apache/solr-sandbox/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Add the requet back to the queue on fail, not just the last record. [solr-sandbox]
Posted by "sigram (via GitHub)" <gi...@apache.org>.
sigram commented on code in PR #75:
URL: https://github.com/apache/solr-sandbox/pull/75#discussion_r1344396006
##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -329,7 +329,7 @@ void processResult(ConsumerRecord<String,MirroredSolrRequest> record, IQueueHand
log.trace("result=failed-resubmit");
}
metrics.counter("failed-resubmit").inc();
- kafkaMirroringSink.submit(record.value());
+ kafkaMirroringSink.submit(result.newItem());
Review Comment:
this should do the trick :)
BTW, I don't like the name `_newItem` and this method suggests as if we were creating something new, which we're not. Why not `item` and `getItem()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org