[jira] [Commented] (HDFS-1727) fsck command can display command usage if user passes any illegal argument

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038634#comment-13038634 ] 

Hadoop QA commented on HDFS-1727:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480252/HDFS-1727.patch
  against trunk revision 1126795.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
                  org.apache.hadoop.hdfs.TestFSOutputSummer

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/617//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/617//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/617//console

This message is automatically generated.

> fsck command can display command usage if user passes any illegal argument
> --------------------------------------------------------------------------
>
>                 Key: HDFS-1727
>                 URL: https://issues.apache.org/jira/browse/HDFS-1727
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.1, 0.23.0
>            Reporter: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-1727.patch
>
>
> In fsck command if user passes the arguments like
> ./hadoop fsck -test -files -blocks -racks
> In this case it will take / and will display whole DFS information regarding to files,blocks,racks.
> But here, we are hiding the user mistake. Instead of this, we can display the command usage if user passes any invalid argument like above.
> If user passes illegal optional arguments like
> ./hadoop fsck /test -listcorruptfileblocks instead of
> ./hadoop fsck /test -list-corruptfileblocks also we can display the proper command usage

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira