You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/04/28 10:29:27 UTC
Review Request 58837: Convert all Ambari Views to use yarn package
manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20885
https://issues.apache.org/jira/browse/AMBARI-20885
Repository: ambari
Description
-------
Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
Diffs
-----
contrib/views/capacity-scheduler/pom.xml 7a65ffb
contrib/views/files/pom.xml 478a537
contrib/views/files/src/main/resources/ui/package.json 3f27897
contrib/views/hawq/pom.xml 8089d68
contrib/views/hive-next/pom.xml c0eb774
contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
contrib/views/hive20/pom.xml a583d23
contrib/views/hive20/src/main/resources/ui/package.json 0453a52
contrib/views/hueambarimigration/pom.xml 30e7694
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
contrib/views/jobs/pom.xml 062f15f
contrib/views/pig/pom.xml d89d47e
contrib/views/wfmanager/pom.xml 86c03f9
Diff: https://reviews.apache.org/r/58837/diff/1/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by venkat sairam <ve...@gmail.com>.
> On April 28, 2017, 4:23 p.m., DIPAYAN BHOWMICK wrote:
> >
Fixed it and added yarn.lock files.
- venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/#review173334
-----------------------------------------------------------
On April 29, 2017, 6:26 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58837/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 6:26 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20885
> https://issues.apache.org/jira/browse/AMBARI-20885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 7a65ffb
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 478a537
> contrib/views/files/src/main/resources/ui/package.json 3f27897
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml 8089d68
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml c0eb774
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive20/pom.xml a583d23
> contrib/views/hive20/src/main/resources/ui/package.json 0453a52
> contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml 30e7694
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml 062f15f
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml d89d47e
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/wfmanager/pom.xml 86c03f9
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58837/diff/2/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/#review173334
-----------------------------------------------------------
contrib/views/capacity-scheduler/pom.xml
Line 158 (original), 164 (patched)
<https://reviews.apache.org/r/58837/#comment246354>
Why is this commented out. Please remove it if not required.
- DIPAYAN BHOWMICK
On April 28, 2017, 10:29 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58837/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 10:29 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20885
> https://issues.apache.org/jira/browse/AMBARI-20885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 7a65ffb
> contrib/views/files/pom.xml 478a537
> contrib/views/files/src/main/resources/ui/package.json 3f27897
> contrib/views/hawq/pom.xml 8089d68
> contrib/views/hive-next/pom.xml c0eb774
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
> contrib/views/hive20/pom.xml a583d23
> contrib/views/hive20/src/main/resources/ui/package.json 0453a52
> contrib/views/hueambarimigration/pom.xml 30e7694
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
> contrib/views/jobs/pom.xml 062f15f
> contrib/views/pig/pom.xml d89d47e
> contrib/views/wfmanager/pom.xml 86c03f9
>
>
> Diff: https://reviews.apache.org/r/58837/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/#review173419
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On April 29, 2017, 6:26 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58837/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 6:26 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20885
> https://issues.apache.org/jira/browse/AMBARI-20885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 7a65ffb
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 478a537
> contrib/views/files/src/main/resources/ui/package.json 3f27897
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml 8089d68
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml c0eb774
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive20/pom.xml a583d23
> contrib/views/hive20/src/main/resources/ui/package.json 0453a52
> contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml 30e7694
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml 062f15f
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml d89d47e
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/wfmanager/pom.xml 86c03f9
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58837/diff/2/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/#review173438
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 29, 2017, 6:26 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58837/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 6:26 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20885
> https://issues.apache.org/jira/browse/AMBARI-20885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 7a65ffb
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 478a537
> contrib/views/files/src/main/resources/ui/package.json 3f27897
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml 8089d68
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml c0eb774
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive20/pom.xml a583d23
> contrib/views/hive20/src/main/resources/ui/package.json 0453a52
> contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml 30e7694
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml 062f15f
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml d89d47e
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/wfmanager/pom.xml 86c03f9
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58837/diff/2/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/
-----------------------------------------------------------
(Updated April 30, 2017, 6:16 p.m.)
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Changes
-------
Added --pure-lockfile option to yarn install, added yarn.lock file to yarn exclude list.
Bugs: AMBARI-20885
https://issues.apache.org/jira/browse/AMBARI-20885
Repository: ambari
Description
-------
Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
Diffs (updated)
-----
contrib/views/capacity-scheduler/pom.xml 7a65ffb
contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/files/pom.xml 478a537
contrib/views/files/src/main/resources/ui/package.json 3f27897
contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hawq/pom.xml 8089d68
contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hive-next/pom.xml c0eb774
contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hive20/pom.xml a583d23
contrib/views/hive20/src/main/resources/ui/package.json 0453a52
contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hueambarimigration/pom.xml 30e7694
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
contrib/views/jobs/pom.xml 062f15f
contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/pig/pom.xml d89d47e
contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
contrib/views/pom.xml 6dcfce2
contrib/views/wfmanager/pom.xml 86c03f9
contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
Diff: https://reviews.apache.org/r/58837/diff/4/
Changes: https://reviews.apache.org/r/58837/diff/3-4/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/
-----------------------------------------------------------
(Updated April 30, 2017, 6:37 a.m.)
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Changes
-------
Added moment libabry ember-cli reference.
Bugs: AMBARI-20885
https://issues.apache.org/jira/browse/AMBARI-20885
Repository: ambari
Description
-------
Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
Diffs (updated)
-----
contrib/views/capacity-scheduler/pom.xml 7a65ffb
contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/files/pom.xml 478a537
contrib/views/files/src/main/resources/ui/package.json 3f27897
contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hawq/pom.xml 8089d68
contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hive-next/pom.xml c0eb774
contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hive20/pom.xml a583d23
contrib/views/hive20/src/main/resources/ui/package.json 0453a52
contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hueambarimigration/pom.xml 30e7694
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
contrib/views/jobs/pom.xml 062f15f
contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/pig/pom.xml d89d47e
contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
contrib/views/wfmanager/pom.xml 86c03f9
contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
Diff: https://reviews.apache.org/r/58837/diff/3/
Changes: https://reviews.apache.org/r/58837/diff/2-3/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 58837: Convert all Ambari Views to use yarn package
manager
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/
-----------------------------------------------------------
(Updated April 29, 2017, 6:26 a.m.)
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20885
https://issues.apache.org/jira/browse/AMBARI-20885
Repository: ambari
Description
-------
Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json.
Diffs (updated)
-----
contrib/views/capacity-scheduler/pom.xml 7a65ffb
contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/files/pom.xml 478a537
contrib/views/files/src/main/resources/ui/package.json 3f27897
contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hawq/pom.xml 8089d68
contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hive-next/pom.xml c0eb774
contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f
contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hive20/pom.xml a583d23
contrib/views/hive20/src/main/resources/ui/package.json 0453a52
contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hueambarimigration/pom.xml 30e7694
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
contrib/views/jobs/pom.xml 062f15f
contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/pig/pom.xml d89d47e
contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
contrib/views/wfmanager/pom.xml 86c03f9
contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
Diff: https://reviews.apache.org/r/58837/diff/2/
Changes: https://reviews.apache.org/r/58837/diff/1-2/
Testing
-------
Manual testing done.
Thanks,
venkat sairam