You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pradeep Soundararajan <pr...@citrix.com> on 2013/03/13 13:46:32 UTC

Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/
-----------------------------------------------------------

Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.


Description
-------

BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.

Signed-off-by: Pradeep <pr...@citrix.com>
--------------------------------------------------------------------------------------

Now package.sh will act based on the below usage i.e. with or without arguments:

 ./package.sh -h

usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]

The commonly used Arguments are:
oss|OSS         To package OSS specific
nonoss|NONOSS   To package NONOSS specific

Examples: ./package.sh -p|--pack oss|OSS
          ./package.sh -p|--pack nonoss|NONOSS
          ./package.sh (Default OSS)

---------------------------------------------------------------------------------------


Diffs
-----

  packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b 
  packaging/centos63/package.sh 2515ecba11fee3ea8dd5f85884861585392a26cd 

Diff: https://reviews.apache.org/r/9900/diff/


Testing
-------

I have tested these changes. They are working well. Please review and submit it if you are fine.

In future, we can even change the mvn commands as per our need from cloud.spec.


Thanks,

Pradeep Soundararajan


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review18252
-----------------------------------------------------------


Commit 01ea7232d9a7e956277f03c8471d8d4e2b60d699 in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=01ea723 ]

CLOUDSTACK-1252: Failed to download default template in VMware

Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.

Now package.sh will act based on the below usage i.e. with or without
arguments:

 ./package.sh -h

usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]

oss|OSS         To package OSS specific
nonoss|NONOSS   To package NONOSS specific

Examples: ./package.sh -p|--pack oss|OSS
          ./package.sh -p|--pack nonoss|NONOSS
          ./package.sh (Default OSS)

Signed-off-by: Pradeep <pr...@citrix.com>


- ASF Subversion and Git Services


On March 22, 2013, 10:21 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 10:21 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec a7a6927 
>   packaging/centos63/package.sh 2515ecb 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review18352
-----------------------------------------------------------

Ship it!


applied to 4.1

- Chip Childers


On March 22, 2013, 10:21 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 10:21 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec a7a6927 
>   packaging/centos63/package.sh 2515ecb 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review18350
-----------------------------------------------------------


Commit 8d3a7f29b8307bff10a66d7871ad9c83f26deb1c in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8d3a7f2 ]

BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Proposing to modify the behaviour of package.sh script. Package as per OSS or NONOSS arguments.

Signed-off-by: Pradeep <pr...@citrix.com>


- ASF Subversion and Git Services


On March 22, 2013, 10:21 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 10:21 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec a7a6927 
>   packaging/centos63/package.sh 2515ecb 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review18314
-----------------------------------------------------------


Commit 01ea7232d9a7e956277f03c8471d8d4e2b60d699 in branch refs/heads/bvt from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=01ea723 ]

CLOUDSTACK-1252: Failed to download default template in VMware

Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.

Now package.sh will act based on the below usage i.e. with or without
arguments:

 ./package.sh -h

usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]

oss|OSS         To package OSS specific
nonoss|NONOSS   To package NONOSS specific

Examples: ./package.sh -p|--pack oss|OSS
          ./package.sh -p|--pack nonoss|NONOSS
          ./package.sh (Default OSS)

Signed-off-by: Pradeep <pr...@citrix.com>


- ASF Subversion and Git Services


On March 22, 2013, 10:21 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 10:21 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec a7a6927 
>   packaging/centos63/package.sh 2515ecb 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by Pradeep Soundararajan <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/
-----------------------------------------------------------

(Updated March 22, 2013, 10:21 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.


Changes
-------

Updated the patch. It is for 4.1 only, let me create a patch for master.


Description
-------

BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.

Signed-off-by: Pradeep <pr...@citrix.com>
--------------------------------------------------------------------------------------

Now package.sh will act based on the below usage i.e. with or without arguments:

 ./package.sh -h

usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]

The commonly used Arguments are:
oss|OSS         To package OSS specific
nonoss|NONOSS   To package NONOSS specific

Examples: ./package.sh -p|--pack oss|OSS
          ./package.sh -p|--pack nonoss|NONOSS
          ./package.sh (Default OSS)

---------------------------------------------------------------------------------------


Diffs (updated)
-----

  packaging/centos63/cloud.spec a7a6927 
  packaging/centos63/package.sh 2515ecb 

Diff: https://reviews.apache.org/r/9900/diff/


Testing
-------

I have tested these changes. They are working well. Please review and submit it if you are fine.

In future, we can even change the mvn commands as per our need from cloud.spec.


Thanks,

Pradeep Soundararajan


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review18251
-----------------------------------------------------------


A few things to fix before applying the patch:

1. There are trailing whitespaces in the patch, I removed those but the patch is corrupt. So please resubmit.
2. The if-elif-else block is not formatted, can you please fix it?
3. Minor nitpick : but use less verbose error strings.

- Prasanna Santhanam


On March 13, 2013, 12:46 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 12:46 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b 
>   packaging/centos63/package.sh 2515ecba11fee3ea8dd5f85884861585392a26cd 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by Pradeep Soundararajan <pr...@citrix.com>.

> On March 15, 2013, 12:49 a.m., Chip Childers wrote:
> > I'd like Wido, David, Hugo or Noa to review this before it's committed to 4.1 please.
> > 
> > Has this been tested on master?

Chip, this patch is not related to any branch specific. These changes are common for packaging.


- Pradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review17932
-----------------------------------------------------------


On March 13, 2013, 12:46 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 12:46 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b 
>   packaging/centos63/package.sh 2515ecba11fee3ea8dd5f85884861585392a26cd 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review17932
-----------------------------------------------------------


I'd like Wido, David, Hugo or Noa to review this before it's committed to 4.1 please.

Has this been tested on master?

- Chip Childers


On March 13, 2013, 12:46 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 12:46 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b 
>   packaging/centos63/package.sh 2515ecba11fee3ea8dd5f85884861585392a26cd 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


RE: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Posted by Animesh Chaturvedi <an...@citrix.com>.
Folks please review and apply this patch. It is  for an important 4.1 fix 

> -----Original Message-----
> From: Pradeep Soundararajan [mailto:noreply@reviews.apache.org] On
> Behalf Of Pradeep Soundararajan
> Sent: Wednesday, March 13, 2013 5:47 AM
> To: David Nalley; Noa Resare; Hugo Trippaers; Alex Huang; Wido den
> Hollander; Chip Childers
> Cc: cloudstack; Pradeep Soundararajan
> Subject: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary:
> Failed to download default template in VMware
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers,
> Alex Huang, Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template
> in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS
> arguments.
> 
> Signed-off-by: Pradeep <pr...@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without
> arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec
> 1b2c9a9633e161081809c3aa25574fdb863d4d0b
>   packaging/centos63/package.sh
> 2515ecba11fee3ea8dd5f85884861585392a26cd
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and
> submit it if you are fine.
> 
> In future, we can even change the mvn commands as per our need from
> cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan