You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/11/18 23:40:47 UTC

Review Request 28188: Added label to ModelTask test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

ModelTask needed to be updated to parse new labels field.


Diffs
-----

  src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 

Diff: https://reviews.apache.org/r/28188/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen


Re: Review Request 28188: Added label to ModelTask test.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/#review62052
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28154, 28155, 28156, 28157, 28158, 28188]

All tests passed.

- Mesos ReviewBot


On Nov. 18, 2014, 10:40 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28188/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 10:40 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> ModelTask needed to be updated to parse new labels field.
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 
> 
> Diff: https://reviews.apache.org/r/28188/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 28188: Added label to ModelTask test.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/#review62042
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Nov. 18, 2014, 10:40 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28188/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 10:40 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> ModelTask needed to be updated to parse new labels field.
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 
> 
> Diff: https://reviews.apache.org/r/28188/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 28188: Added label to ModelTask test.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 4:08 p.m.)


Review request for mesos.


Changes
-------

Rebase NNFR


Repository: mesos-git


Description
-------

ModelTask needed to be updated to parse new labels field.


Diffs (updated)
-----

  src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 

Diff: https://reviews.apache.org/r/28188/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen