[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41126: [SPARK-43383][SQL][FOLLOWUP] Use the same method to compute LocalRelation's data length.

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #41126:
URL: https://github.com/apache/spark/pull/41126#discussion_r1190617514


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala:
##########
@@ -80,7 +80,7 @@ case class LocalRelation(
 
   override def computeStats(): Statistics =
     Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length,
-      rowCount = Some(data.size))
+      rowCount = Some(data.length))

Review Comment:
   Actually, this was mentioned by @HyukjinKwon first. I thought it's addressed.
   - https://github.com/apache/spark/pull/41064#discussion_r1186956202



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org