[GitHub] [beam] azurezyq commented on a change in pull request #14547: Populate runtime parameters in SDK worker startup.

[GitBox <gi...@apache.org>]

azurezyq commented on a change in pull request #14547:
URL: https://github.com/apache/beam/pull/14547#discussion_r616191663



##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker_main.py
##########
@@ -105,27 +106,19 @@ def main(unused_argv):
   else:
     fn_log_handler = None
 
-  # Start status HTTP server thread.
-  thread = threading.Thread(
-      name='status_http_server', target=StatusServer().start)
-  thread.daemon = True
-  thread.setName('status-server-demon')
-  thread.start()
-
-  if 'PIPELINE_OPTIONS' in os.environ:
-    sdk_pipeline_options = _parse_pipeline_options(
-        os.environ['PIPELINE_OPTIONS'])
-  else:
-    sdk_pipeline_options = PipelineOptions.from_dictionary({})
+  pipeline_options_dict = _load_pipeline_options(
+      environment.get('PIPELINE_OPTIONS'))
+  RuntimeValueProvider.set_runtime_options(pipeline_options_dict)

Review comment:
       Better to add a comment here to describe its purpose.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org